Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 60342: Fix nested volume mounts for read-only API data volumes #18766

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Feb 27, 2018

What this PR does / why we need it:
Since the runtime may try to create mount points within the sandbox, it will fail if the mount point is within a read-only API data volume, like a secret or configMap volume.

Create any needed mount points during volume setup.

xref kubernetes/kubernetes#60342

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Release note:
No release notes because we haven't released anything (yet) that has this bug.

NONE

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 27, 2018
@joelsmith
Copy link
Contributor Author

/retest

@sjenning sjenning added the kind/bug Categorizes issue or PR as related to a bug. label Feb 28, 2018
@sjenning
Copy link
Contributor

/lgtm
@jsafrane can you approve?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2018
@jsafrane
Copy link
Contributor

jsafrane commented Mar 1, 2018

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, jsafrane, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2018
@joelsmith
Copy link
Contributor Author

/test unit

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@joelsmith
Copy link
Contributor Author

/test extended_networking_minimal

@joelsmith joelsmith added this to the 3.9.0 milestone Mar 1, 2018
@joelsmith
Copy link
Contributor Author

/cherrypick release-3.9

@openshift-cherrypick-robot

@joelsmith: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-cherrypick-robot

@joelsmith: new pull request created: #18789

In response to this:

/cherrypick release-3.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants