Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.9] UPSTREAM: 60342: Fix nested volume mounts for read-only API data volumes #18789

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #18766

/assign joelsmith

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 1, 2018
@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Mar 1, 2018
@joelsmith
Copy link
Contributor

/retest

1 similar comment
@sjenning
Copy link
Contributor

sjenning commented Mar 1, 2018

/retest

@joelsmith
Copy link
Contributor

Trying again now that openshift-eng/aos-cd-jobs#1176 is merged.
/test extended_conformance_install

@sjenning
Copy link
Contributor

sjenning commented Mar 1, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2018
@eparis
Copy link
Member

eparis commented Mar 2, 2018

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, openshift-cherrypick-robot, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@joelsmith
Copy link
Contributor

/test gcp

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@joelsmith
Copy link
Contributor

/retest

@joelsmith
Copy link
Contributor

joelsmith commented Mar 5, 2018

Flaking on #18823
/retest
The gcp test is probably going to keep failing until #18843 merges.

@derekwaynecarr derekwaynecarr merged commit 30c11ad into openshift:release-3.9 Mar 5, 2018
@derekwaynecarr
Copy link
Member

manually merged this when i meant to merge #18823

leaving them both in for now to see if queue remains clean.

@joelsmith
Copy link
Contributor

Sweet, a shortcut! Thanks @derekwaynecarr I'll keep an eye on the tests in the release-3.9 branch to see if any are related to my change.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp ea709a2 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants