Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename selectmenu to selectlist #788

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

josepharhar
Copy link
Collaborator

This was resolved here:
#773

@josepharhar
Copy link
Collaborator Author

@andrico1234 do you know why this build failed?

@gregwhitworth
Copy link
Member

@josepharhar logs show the following problems:

1:28:03 PM: [1/4] Resolving packages...
1:28:03 PM: warning @fortawesome/[email protected]: Please upgrade to 6.1.0. https://fontawesome.com/docs/changelog/
1:28:03 PM: warning @fortawesome/fontawesome-svg-core > @fortawesome/[email protected]: Please upgrade to 6.1.0. https://fontawesome.com/docs/changelog/
1:28:13 PM: error Couldn't find any versions for astro-compress that matches ^1.1.10
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
1:28:13 PM: Error during Yarn install
1:28:13 PM: Build was terminated: dependency_installation script returned non-zero exit code: 1
1:28:13 PM: Failing build: Failed to install dependencies

Copy link
Collaborator

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is a pure search/replace of "selectmenu" with "selectlist". (It's hard to tell because the diff doesn't think it's a rename.)

Assuming so, LGTM.

@andrico1234
Copy link
Collaborator

andrico1234 commented Aug 12, 2023

Sorry for the delay folks, I have a PR open for this fix (along with a description of the problem).

#791

@josepharhar , you'll likely need to merge from main once my fix goes in. Let me know if you need a hand with anything else

@andrico1234
Copy link
Collaborator

CC - @josepharhar

The fix has been merged, you should be unblocked now 😄

@josepharhar
Copy link
Collaborator Author

Thanks, I merged with the new commits.
Weird though, it looks like there were no checks that ran on my latest commit. I'll click the "squash and merge" button anyway since it seems happy

@josepharhar josepharhar merged commit bc3e73e into openui:main Aug 15, 2023
@josepharhar josepharhar deleted the rename branch August 15, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants