-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename selectmenu to selectlist #788
Conversation
This was resolved here: openui#773
@andrico1234 do you know why this build failed? |
@josepharhar logs show the following problems:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is a pure search/replace of "selectmenu" with "selectlist". (It's hard to tell because the diff doesn't think it's a rename.)
Assuming so, LGTM.
Sorry for the delay folks, I have a PR open for this fix (along with a description of the problem). @josepharhar , you'll likely need to merge from main once my fix goes in. Let me know if you need a hand with anything else |
CC - @josepharhar The fix has been merged, you should be unblocked now 😄 |
Thanks, I merged with the new commits. |
This was resolved here:
#773