Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segmentation] Enable feature vector output for MPA Segmentation #1158

Merged
merged 18 commits into from
Aug 9, 2022
Merged

[Segmentation] Enable feature vector output for MPA Segmentation #1158

merged 18 commits into from
Aug 9, 2022

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Jul 7, 2022 •
edited
Loading

@eugene123tw eugene123tw requested a review from a team as a code owner July 7, 2022 17:04
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jul 7, 2022
@eugene123tw
Copy link
Contributor Author

run ote-test

goodsong81
goodsong81 requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inference task looks good to me. Could you add OpenVINO IR support for feature vector / map output?

@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

run ote-test

@JihwanEom
Copy link
Contributor

JihwanEom commented Jul 28, 2022 •
edited
Loading

Hi @chuneuny-emily , could you review this PR for segmentation task? mmseg submodule is updated on this PR, so I'm worried for cls_incr_segmentor.

chuneuny-emily
chuneuny-emily requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@chuneuny-emily chuneuny-emily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side effect occurs while training. Please check my comment.

external/model-preparation-algorithm/mpa_tasks/apis/segmentation/task.py Show resolved Hide resolved
chuneuny-emily
chuneuny-emily previously approved these changes Jul 29, 2022
View reviewed changes
chuneuny-emily
chuneuny-emily requested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@chuneuny-emily chuneuny-emily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the side effect on mmsegmentation first before merging this PR, and update mmseg submodule commit.

chuneuny-emily
chuneuny-emily previously approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@chuneuny-emily chuneuny-emily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No side effect on train/eval/export/optimize.

JihwanEom
JihwanEom previously approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@JihwanEom JihwanEom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM API Any changes in OTX API labels Aug 4, 2022
@JihwanEom JihwanEom mentioned this pull request Aug 5, 2022
Closed
JihwanEom
JihwanEom approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@JihwanEom JihwanEom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add descriptions on this PR about OTE_SDK version update for deployment code or CVS-84981 (OMZ) ?

@eugene123tw eugene123tw merged commit 0c34cb5 into develop Aug 9, 2022
@eugene123tw eugene123tw deleted the eugene/CVS-86547-enable-saliency-mpa-seg branch August 9, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JihwanEom JihwanEom JihwanEom approved these changes

@chuneuny-emily chuneuny-emily chuneuny-emily approved these changes

@harimkang harimkang harimkang approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eugene123tw @JihwanEom @goodsong81 @harimkang @chuneuny-emily