Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV] Fix deprecated np.bool issue from numpy==1.24.0 #1455

Merged
merged 9 commits into from
Dec 23, 2022
Merged

[DEV] Fix deprecated np.bool issue from numpy==1.24.0 #1455

merged 9 commits into from
Dec 23, 2022

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Dec 20, 2022 •
edited
Loading

  • Restrict numpy<=1.23.5 which allows np.bool (OpenVINO runtime is using it)
  • Enhance CLI test run for better error message
    • Now we can see stack trace from CLI test failure.
      image

@github-actions github-actions bot added CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM API Any changes in OTX API labels Dec 20, 2022
@goodsong81 goodsong81 force-pushed the songkich/better-cli-test/develop branch from d7cc526 to 7de1514 Compare December 20, 2022 06:36
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Dec 20, 2022
@goodsong81
Copy link
Contributor Author

goodsong81 commented Dec 20, 2022 •
edited
Loading

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/853/

@goodsong81
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/854/

@goodsong81
Capture stderr only
cabdec3 
Signed-off-by: Songki Choi <[email protected]>
@goodsong81 goodsong81 force-pushed the songkich/better-cli-test/develop branch from c1d2e7a to cabdec3 Compare December 21, 2022 00:53
@goodsong81
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/858/

@goodsong81 goodsong81 changed the title [DEV] Fix CLI test run for better error message [DEV] Fix deprecated np.bool issue from numpy==1.24.0 Dec 21, 2022
@goodsong81 goodsong81 mentioned this pull request Dec 21, 2022
Merged
@goodsong81 goodsong81 marked this pull request as ready for review December 21, 2022 02:20
@goodsong81 goodsong81 requested a review from a team as a code owner December 21, 2022 02:20
@goodsong81
Copy link
Contributor Author

goodsong81 commented Dec 21, 2022 •
edited
Loading

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/859/
The only failure was precommit test, which was resolved now.
image

@goodsong81
Fix precommit issue
ee96380 
Signed-off-by: Songki Choi <[email protected]>
@github-actions github-actions bot added the TEST Any changes in tests label Dec 23, 2022
sungmanc
sungmanc previously approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we need to answer #1456

harimkang
harimkang previously approved these changes Dec 23, 2022
View reviewed changes
@goodsong81
Copy link
Contributor Author

LGTM. we need to answer #1456

Will do. I'm testing. Might need minor change.

harimkang
harimkang approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sungmanc sungmanc merged commit 40c2a1e into develop Dec 23, 2022
@sungmanc sungmanc deleted the songkich/better-cli-test/develop branch December 23, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

@harimkang harimkang harimkang approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goodsong81 @harimkang @sungmanc