Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTX] Fix deprecated np.bool issue from numpy==1.24.0 #1456

Merged
merged 7 commits into from
Dec 26, 2022
Merged

[OTX] Fix deprecated np.bool issue from numpy==1.24.0 #1456

merged 7 commits into from
Dec 26, 2022

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Dec 20, 2022 •
edited
Loading

Same as #1455

@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Dec 20, 2022
@goodsong81
Capture stderr only
bd8638d 
Signed-off-by: Songki Choi <[email protected]>
@github-actions github-actions bot added the CLI Any changes in OTE CLI label Dec 21, 2022
@goodsong81 goodsong81 changed the title [OTX] Fix CLI test run for better error message [OTX] Fix deprecated np.bool issue from numpy==1.24.0 Dec 21, 2022
@goodsong81 goodsong81 marked this pull request as ready for review December 21, 2022 02:19
@goodsong81 goodsong81 requested a review from a team as a code owner December 21, 2022 02:19
sungmanc
sungmanc previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ minor comment

otx/api/usecases/exportable_code/demo/requirements.txt Outdated
@@ -1,2 +1,3 @@
openmodelzoo-modelapi==2022.2.0
otx @ git+https://github.com/openvinotoolkit/training_extensions/@e12437e6660b257731e76192344d01c70f603f73#egg=otx
numpy<=1.23.5 # np.bool was removed in 1.24.0 which was used in openvino runtime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using numpy>=1.21.0,<=1.23.5 ? Like same as below figure
image

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this conflict with the NNCF and OpenVINO installation? I'm getting errors during the installation which following the quick start guide.

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
openvino 2022.1.0 requires numpy<1.20,>=1.16.6, but you have numpy 1.24.0 which is incompatible.
openvino-dev 2022.1.0 requires numpy<1.20,>=1.16.6, but you have numpy 1.24.0 which is incompatible.
openvino-dev 2022.1.0 requires numpy<=1.21,>=1.16.6; python_version > "3.6", but you have numpy 1.24.0 which is incompatible.
openmodelzoo-modelapi 0.0.0 requires numpy<=1.21,>=1.16.6; python_version > "3.6", but you have numpy 1.24.0 which is incompatible.
nncf 2.1.0.dev0+e85a695d requires numpy~=1.19.2, but you have numpy 1.24.0 which is incompatible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, this is feature/otx branch PR.
You may want to check develop branch PR: #1455

Yes, there are some version mismatches that pip is complaining when you run init_venv.sh.
But it will work well actually.

This mismatch will be resolved after we could upgrade the OpenVINO version by #1393

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goodsong81 it seems like OV-dev 2022.3 requires np < 1.24 anyway

@goodsong81
Align numpy requirement
4fa0704 
Signed-off-by: Songki Choi <[email protected]>
@goodsong81 goodsong81 mentioned this pull request Dec 23, 2022
Merged
@goodsong81
Copy link
Contributor Author

2 failures are OpenVINO accuracy issues that occur sometimes. Let' merge this PR.
image

@goodsong81 goodsong81 merged commit 743a3fc into feature/otx Dec 26, 2022
@goodsong81 goodsong81 deleted the songkich/better-cli-test/otx branch December 26, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asutic asutic asutic left review comments

@sovrasov sovrasov sovrasov left review comments

@sungmanc sungmanc sungmanc approved these changes

@harimkang harimkang harimkang approved these changes

Assignees
No one assigned
Labels
CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@goodsong81 @sovrasov @asutic @harimkang @sungmanc