fix(question-answer): question answer protocol state/role check

[genaris]

Some fixes and additional checks in process methods from QuestionAnswerService that are preventing it to correctly accept/reject the received message.

Add some service tests as well as a simple E2E module test that allowed to find and fix a weird issue with parameter construction: ValidResponse takes another ValidResponse as input and this could make message validation to fail.

No API changes were introduced apart from adding a findById method.

Signed-off-by: Ariel Gentile [email protected]

[codecov-commenter]

Codecov Report

Merging #1001 (75e4ba2) into main (f487182) will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
+ Coverage   88.06%   88.50%   +0.44%     
==========================================
  Files         492      492              
  Lines       11623    11636      +13     
  Branches     1936     1938       +2     
==========================================
+ Hits        10236    10299      +63     
+ Misses       1326     1277      -49     
+ Partials       61       60       -1     

Impacted Files	Coverage Δ
...rc/modules/question-answer/QuestionAnswerModule.ts	95.55% <100.00%> (+37.01%)	⬆️
...question-answer/repository/QuestionAnswerRecord.ts	100.00% <100.00%> (+10.71%)	⬆️
.../question-answer/services/QuestionAnswerService.ts	92.10% <100.00%> (+34.96%)	⬆️
...odules/question-answer/messages/QuestionMessage.ts	100.00% <0.00%> (+4.34%)	⬆️
...s/question-answer/handlers/AnswerMessageHandler.ts	100.00% <0.00%> (+28.57%)	⬆️
...question-answer/handlers/QuestionMessageHandler.ts	100.00% <0.00%> (+28.57%)	⬆️
...rc/modules/question-answer/models/ValidResponse.ts	100.00% <0.00%> (+75.00%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.