test(credentials): fix flaky tests with events #966
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
…oGlastra/aries-framework-javascript into test/credentials-flaky-tests
Signed-off-by: 2byrds <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
=======================================
Coverage 88.18% 88.18%
=======================================
Files 488 488
Lines 11552 11552
Branches 1921 1921
=======================================
Hits 10187 10187
Misses 1305 1305
Partials 60 60 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
2byrds
force-pushed
the
test/credentials-flaky-tests
branch
from
b86b43d
to
7c78859
Compare
@TimoGlastra how does auto-accept test look? i'll learn from your suggestions before continuing to other test files. packages/core/src/modules/credentials/protocol/v2/tests/v2-credentials-auto-accept.e2e.test.ts |
|
Sorry for the delayed response again. But looks perfect! |
No sorry necessary. You get a mega-gold-star for replying so quickly after returning from vacation. I thought it was high risk to put that on your queue while you were away. But you got to it faster than I would have guessed :). Okay I'll keep chugging in this direction. |
|
@TimoGlastra in your original ticket you said we should handle the ppv2 e2e tests as well (as the icv2 e2e tests). I don't see a similar directory and naming for proof tests (like there is for icv2 e2e tests). Looks like I should probably modify packages/core/tests/proofs.test.ts and proofs-auto-accept.test.ts but I wanted to verify with you, first. |
|
I think we should make these updates to the 0.3.0-pre as that introcuded a lot of changes to the present proof module. If the credential tests are done we can merge this PR and address that in a separate PR. |
Sounds good. Triggering review. |
Signed-off-by: Ariel Gentile <[email protected]> fix: expose oob domain (openwallet-foundation#990) fix: some changes based on feedback Signed-off-by: Ariel Gentile <[email protected]> docs: a few clarifications and TODOs Signed-off-by: Ariel Gentile <[email protected]> feat: combine features Signed-off-by: Ariel Gentile <[email protected]> test(credentials): fix flaky tests with events (openwallet-foundation#966) Signed-off-by: 2byrds <[email protected]> feat: OOB public did (openwallet-foundation#930) Signed-off-by: Pavel Zarecky <[email protected]> feat(routing): manual mediator pickup lifecycle management (openwallet-foundation#989) Signed-off-by: Ariel Gentile <[email protected]> docs(demo): faber creates invitation (openwallet-foundation#995) Signed-off-by: conanoc <[email protected]> chore(release): v0.2.3 (openwallet-foundation#999) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> fix: disclosures message fields and optional thid Signed-off-by: Ariel Gentile <[email protected]> fix(question-answer): question answer protocol state/role check (openwallet-foundation#1001) Signed-off-by: Ariel Gentile <[email protected]> refactor: move feature registration to module Signed-off-by: Ariel Gentile <[email protected]> fix: dependency manager test Signed-off-by: Ariel Gentile <[email protected]> fix: feature registry instance Signed-off-by: Ariel Gentile <[email protected]>
Include similar fixes for other ice2e tests like @TimoGlastra
started in #893