Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow agent without inbound endpoint to connect when using multi-use invitation #712

Conversation

TimoGlastra
Copy link
Contributor

Quite an edge case, but when an agent without an inbound endpoint (e.g. mobile wallet connecting to mediator) would respond to a multi-use connection invitation (quite common with mediators) the session would be stored for the multi-use invitation connection. But during the processing of the request a new connection will be created, which means the session won't be reused afterwards because it's tied to the multi-use invitation connection.

Normally this isn't that big a deal, as the next time a message is sent using the new connection the session can be reused, but for agent without an inbound transport this made it impossible to connect to AFJ.

This PR adds the sessionId to the inbound message, and later attaches it to the outbound message. This is only used when directly responding to an incoming message. Wasn't sure if attaching the sessionId is the best here, but couldn't think of other straightforward approaches. We basically want to attach it to the inbound message, so we can just respond to the inbound session (instead of finding a session by the connection id, which is still used for a lot of other use cases)

Also changed the subject transport a bit to not require an inbound transport anymore when no inbound endpoint is configured (better reflects real-world setup)

Fixes #483

Previously the session is only stored by the connection id, but this is not always enough for the session to be reused. When using a multi-use invitation the connection id will change while processing the message, meaning the session cannot be reused. This also helps with cases where no connection is established. Fixes openwallet-foundation#483

Signed-off-by: Timo Glastra <[email protected]>
This allows restarting of recipient agents and creating new subjects while e.g. the mediator stays awake. This basically mimics opening and closing http/ws sockets

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra requested a review from a team as a code owner April 15, 2022 21:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #712 (11feb8b) into main (75fb99e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   86.81%   86.84%   +0.02%     
==========================================
  Files         358      358              
  Lines        7806     7812       +6     
  Branches     1205     1316     +111     
==========================================
+ Hits         6777     6784       +7     
+ Misses       1028      974      -54     
- Partials        1       54      +53     
Impacted Files Coverage Δ
packages/core/src/types.ts 100.00% <ø> (ø)
packages/core/src/agent/Dispatcher.ts 83.63% <100.00%> (+0.30%) ⬆️
packages/core/src/agent/MessageReceiver.ts 77.68% <100.00%> (+0.18%) ⬆️
packages/core/src/agent/MessageSender.ts 74.26% <100.00%> (+0.58%) ⬆️
packages/core/src/agent/TransportService.ts 100.00% <100.00%> (+7.40%) ⬆️
...ges/core/src/agent/models/InboundMessageContext.ts 92.30% <100.00%> (+0.64%) ⬆️
packages/core/src/storage/IndyStorageService.ts 89.32% <0.00%> (-0.98%) ⬇️
packages/node/src/NodeFileSystem.ts 37.14% <0.00%> (ø)
packages/core/src/crypto/JwsService.ts 90.90% <0.00%> (ø)
packages/core/src/utils/transformers.ts 69.44% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75fb99e...11feb8b. Read the comment docs.

Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too much noticeable for me. I am not that well familiar with the inbound/outbound transport so I just commented more on some general code quality.

session = this.transportService.findSessionById(sessionId)
}
if (!session) {
session = this.transportService.findSessionByConnectionId(connection.id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done nicely in a ternary expression instead of a let with if/else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, but that won't work in this case because I want to find as session by id if the session id is present, and if there is no session form that first step then I want to find the session by connection id.

So it could be that both methods are called, and with a ternerary only one of the two will be called

tests/transport/SubjectOutboundTransport.ts Outdated Show resolved Hide resolved
@TimoGlastra TimoGlastra enabled auto-merge (squash) May 1, 2022 20:58
@TimoGlastra TimoGlastra merged commit 01c5bb3 into openwallet-foundation:main May 1, 2022
karimStekelenburg added a commit to animo/aries-framework-javascript that referenced this pull request May 19, 2022
fix(core): expose record metadata types (openwallet-foundation#556)

Signed-off-by: Berend Sliedrecht <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
ci: create non-annotated tags (openwallet-foundation#559)

Signed-off-by: Timo Glastra <[email protected]>
style: non-null assertions and newline import (openwallet-foundation#561)

Signed-off-by: Timo Glastra <[email protected]>
chore: disable unnecessary type check in Dispatcher test (openwallet-foundation#565)

Signed-off-by: Jakub Koci <[email protected]>
ci: add continuous deployment scripts (openwallet-foundation#552)

Signed-off-by: Timo Glastra <[email protected]>
feat: expose wallet API (openwallet-foundation#566)

This commit also contains the following changes:
* Create a master secret when creating a wallet.
* Do not delete wallet when shutdown is called on agent.
* Expose the whole wallet API, which also contains methods that should be used only inside the framework. We need to improve that in the future.

Signed-off-by: Jakub Koci <[email protected]>

BREAKING CHANGE: The agent’s `shutdown` method does not delete the wallet anymore. If you want to delete the wallet, you can do it via exposed wallet API.
build: add arm test ledger setup (openwallet-foundation#573)

Signed-off-by: Timo Glastra <[email protected]>
feat: add problem report protocol (openwallet-foundation#560)

Signed-off-by: Amit Padmani <[email protected]>
docs: added report problem protocol to README (openwallet-foundation#574)

Signed-off-by: Berend Sliedrecht <[email protected]>
fix: support mediation for connectionless exchange (openwallet-foundation#577)

Signed-off-by: Timo Glastra <[email protected]>
refactor(core): separate logic for inbound plaintext and encrypted message (openwallet-foundation#581)

* rename wire message to encrypted message

Signed-off-by: Jakub Koci <[email protected]>
feat: generic attachment handler (openwallet-foundation#578)

Signed-off-by: morrieinmaas <[email protected]>
Co-authored-by: annelein <[email protected]>
refactor: resolve feedback for problem report (openwallet-foundation#584)

Signed-off-by: Amit Padmani <[email protected]>
fix(core)!: Improved typing on metadata api (openwallet-foundation#585)

Signed-off-by: Berend Sliedrecht <[email protected]>

BREAKING CHANGE: removed the getAll() function.
chore(release): v0.1.0 (openwallet-foundation#571)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
docs(apple-silicon): update OpenSSL instructions (openwallet-foundation#590)

* docs(apple-silicon): update openssl install instructions

Signed-off-by: Karim Stekelenburg <[email protected]>

* docs(apple-silicon): add missing 'add to path' commands

Signed-off-by: Karim Stekelenburg <[email protected]>

* docs(apple-silicon): run prettier

Signed-off-by: Karim Stekelenburg <[email protected]>
feat(core): allow to set auto accept connetion exchange when accepting invitation (openwallet-foundation#589)

Signed-off-by: Jakub Koci <[email protected]>
feat: ledger connections happen on agent init in background (openwallet-foundation#580)

* Connects to ledger on agent init by default, ledger calls will wait for connections to be complete if so
* Updated version of indy-sdk-react-native to 0.1.16

Signed-off-by: Patrick Kenyon <[email protected]>
feat: add generic did resolver (openwallet-foundation#554)

* feat: did:key, did:web, did:sov resolver

Signed-off-by: Timo Glastra <[email protected]>
feat: add support for signed attachments (openwallet-foundation#595)

Signed-off-by: Timo Glastra <[email protected]>

BREAKING CHANGE: attachment method `getDataAsJson` is now located one level up. So instead of `attachment.data.getDataAsJson()` you should now call `attachment.getDataAsJson()`
build(deps): bump shelljs from 0.8.4 to 0.8.5 (openwallet-foundation#598)

Signed-off-by: dependabot[bot] <[email protected]>
feat: add didcomm message record (openwallet-foundation#593)

Signed-off-by: Timo Glastra <[email protected]>
fix: disallow usage of global buffer (openwallet-foundation#601)

fix: verify jws contains at least 1 signature (openwallet-foundation#600)

feat(core): added timeOut to the module level (openwallet-foundation#603)

* fix(core): added timeOut to the module level

Signed-off-by: Berend Sliedrecht <[email protected]>
feat: add support for did:peer (openwallet-foundation#608)

Signed-off-by: Timo Glastra <[email protected]>
feat: support new did document in didcomm message exchange (openwallet-foundation#609)

* refactor: unify did document services
* feat: integrate did resolver with message sender
* feat: support new did docoument for msg receiver

Signed-off-by: Timo Glastra <[email protected]>
docs: proofs (openwallet-foundation#564)

Signed-off-by: Mostafa <[email protected]>
fix: incorrect encoding of services for did:peer (openwallet-foundation#610)

Signed-off-by: Timo Glastra <[email protected]>
ci: get last alpha package version from npm (openwallet-foundation#611)

We currently use the commit number, but this is incorrect as the number will be reset to 0 again when the next minor version is released.

Signed-off-by: Timo Glastra <[email protected]>
chore: regenerate yarn.lock for security updates (openwallet-foundation#616)

Signed-off-by: Timo Glastra <[email protected]>
ci: prepend v to alpha releases for consistency (openwallet-foundation#617)

Signed-off-by: Timo Glastra <[email protected]>
feat: add find and save/update methods to DidCommMessageRepository (openwallet-foundation#620)

Signed-off-by: NB-Karim <[email protected]>
feat: update recursive backoff & trust ping record updates (openwallet-foundation#631)

Signed-off-by: James Ebert <[email protected]>
fix: leading zeros in credential value encoding (openwallet-foundation#632)

Signed-off-by: James Ebert <[email protected]>
feat: indy revocation (prover & verifier) (openwallet-foundation#592)

* Added recepientRevocation for createProof

Signed-off-by: Patrick Kenyon <[email protected]>

* Initial revocation functions for getRequestedCredentialsForProofRequest

Signed-off-by: Patrick Kenyon <[email protected]>

* Added option to check for revocation status in getRequestedCredentials

Signed-off-by: Patrick Kenyon <[email protected]>

* sorted transports

Signed-off-by: Adam Burdett <[email protected]>

* broken message sender tests

Signed-off-by: Adam Burdett <[email protected]>

* structure fix

Signed-off-by: Adam Burdett <[email protected]>

* lint import ordering

Signed-off-by: Adam Burdett <[email protected]>

* if(0) does not work.

Signed-off-by: Adam Burdett <[email protected]>

* utf-8 decode ws event.data

Signed-off-by: Adam Burdett <[email protected]>

* indy wallet friendly bits

Signed-off-by: Adam Burdett <[email protected]>

* correct protocal type

Signed-off-by: Adam Burdett <[email protected]>

* check invite during init

Signed-off-by: Adam Burdett <[email protected]>

* id check

Signed-off-by: Adam Burdett <[email protected]>

* keep sockets with mediators open

Signed-off-by: Adam Burdett <[email protected]>

* recursive backoff

Signed-off-by: Adam Burdett <[email protected]>

* timeout

Signed-off-by: Adam Burdett <[email protected]>

* timeout time

Signed-off-by: Adam Burdett <[email protected]>

* logger

Signed-off-by: Adam Burdett <[email protected]>

* propper recursive backoff

Signed-off-by: Adam Burdett <[email protected]>

* multiple socket timeout support

Signed-off-by: Adam Burdett <[email protected]>

* Code cleanup

Signed-off-by: Patrick Kenyon <[email protected]>

* Fix tests and types

Signed-off-by: Patrick Kenyon <[email protected]>

* Formatting and type fixes

Signed-off-by: Patrick Kenyon <[email protected]>

* revocation fixes

Signed-off-by: Patrick Kenyon <[email protected]>

* ran prettier

Signed-off-by: Patrick Kenyon <[email protected]>

* chore: add ts ignore until types are updated

Signed-off-by: James Ebert <[email protected]>

* feat: updated tails download to utilize axios and added inline docs

Signed-off-by: James Ebert <[email protected]>

* chore: fixed formatting

Signed-off-by: James Ebert <[email protected]>

* chore: removed husky

Signed-off-by: James Ebert <[email protected]>

* fix: add back husky pre-push

Signed-off-by: James Ebert <[email protected]>

* chore: formatting

Signed-off-by: James Ebert <[email protected]>

* fix: fixed error imports

Signed-off-by: James Ebert <[email protected]>

* chore: resolve dependency loop issues

Signed-off-by: James Ebert <[email protected]>

* chore: formatting

Signed-off-by: James Ebert <[email protected]>

* feature: revocation ledger methods & proof get requested credentials revoked status

Signed-off-by: James Ebert <[email protected]>

* feature: added revocation state creation

Signed-off-by: James Ebert <[email protected]>

* fix: small tweaks and fixes for revocation

Signed-off-by: James Ebert <[email protected]>

* feature: takes into account referent revocation intervals

Signed-off-by: James Ebert <[email protected]>

* chore: cleanup & prettier

Signed-off-by: James Ebert <[email protected]>

* fix: fixed createrevocationstate types & initial rev reg def caching

Signed-off-by: James Ebert <[email protected]>

* chore: formatting

Signed-off-by: James Ebert <[email protected]>

* fix: fixed proofservice test mock

Signed-off-by: James Ebert <[email protected]>

* chore: minor cleanup

Signed-off-by: James Ebert <[email protected]>

* chore: rename indyutilitiesservice

Signed-off-by: James Ebert <[email protected]>

* chore: troubleshooting revocation, added ledger methods for verifying proof of non revocation

Signed-off-by: James Ebert <[email protected]>

* chore: cleanup & credential storage w/revocation

Signed-off-by: James Ebert <[email protected]>

* feat: add download to file method to file system

Signed-off-by: Timo Glastra <[email protected]>

* refactor: use rnfs for react native

Signed-off-by: Timo Glastra <[email protected]>

* chore: cleanup & log adjustments

Signed-off-by: James Ebert <[email protected]>

* chore: formatting

Signed-off-by: James Ebert <[email protected]>

* feat: verify proofs containing proof of non_revocation

Signed-off-by: James Ebert <[email protected]>

* chore: formatting

Signed-off-by: James Ebert <[email protected]>

* chore: update indy-sdk-react-native & indy-sdk types

Signed-off-by: James Ebert <[email protected]>

* chore: adjusts names to be consistent & removing abbreviations

Signed-off-by: James Ebert <[email protected]>

* chore: updated indy-sdk types to fix proof identifier types

Signed-off-by: James Ebert <[email protected]>

* fix: indyverifierservice prototype pollution

Signed-off-by: James Ebert <[email protected]>

Co-authored-by: Patrick Kenyon <[email protected]>
Co-authored-by: Adam Burdett <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
fix: check for "REQNACK" response from indy ledger (openwallet-foundation#626)

Signed-off-by: annelein <[email protected]>
fix: credential preview attributes mismatch schema attributes (openwallet-foundation#625)

Signed-off-by: annelein <[email protected]>
docs: add cli demo (openwallet-foundation#619)

Signed-off-by: annelein <[email protected]>
fix: check proof request group names do not overlap (openwallet-foundation#638)

Signed-off-by: annelein <[email protected]>
fix(core): error if unpacked message does not match JWE structure (openwallet-foundation#639)

Signed-off-by: annelein <[email protected]>
feat: filter retrieved credential by revocation state (openwallet-foundation#641)

Signed-off-by: Timo Glastra <[email protected]>
docs: cleanup demo (openwallet-foundation#645)

Signed-off-by: Berend Sliedrecht <[email protected]>
feat(crypto): add abstract KeyPair class

Signed-off-by: NB-Karim <[email protected]>

feat(crypto): move Key class to crypto directory

Signed-off-by: NB-Karim <[email protected]>

feat(crypto): move multiCodecKey to crypto folder

Signed-off-by: NB-Karim <[email protected]>

feat(crypto): add WalletKeyPair

Signed-off-by: NB-Karim <[email protected]>

style: fix formatting issues

Signed-off-by: NB-Karim <[email protected]>

feat: add wallet key derivation method option (openwallet-foundation#650)

Signed-off-by: Timo Glastra <[email protected]>
fix: issue where attributes and predicates match (openwallet-foundation#640)

Signed-off-by: annelein <[email protected]>
fix(basic-message): assert connection is ready (openwallet-foundation#657)

Signed-off-by: Karim <[email protected]>
test: minor wallet test changes (openwallet-foundation#660)

Signed-off-by: Niall Shaw <[email protected]>
feat: add wallet module with import export (openwallet-foundation#652)

Signed-off-by: Timo Glastra <[email protected]>
refactor(proofs): remove unused method from service (openwallet-foundation#663)

Signed-off-by: Timo Glastra <[email protected]>
fix: agent isinitialized on shutdown (openwallet-foundation#665)

Signed-off-by: Niall Shaw <[email protected]>
fix(routing): remove sentTime from request message (openwallet-foundation#670)

Signed-off-by: Timo Glastra <[email protected]>
feat: add w3c credential models

Signed-off-by: Karim <[email protected]>

feat: add mock W3cCredentialService

Signed-off-by: Karim <[email protected]>

feat: keyPair record

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: generic wallet interface for key types

Signed-off-by: Timo Glastra <[email protected]>

fix: renamed secretKey -> privateKey

Signed-off-by: Berend Sliedrecht <[email protected]>

fix: dependency cycles

Signed-off-by: Karim <[email protected]>

feat: KeyPairRepository

Signed-off-by: Berend Sliedrecht <[email protected]>

docs: improved tsdoc for repository

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: restructured wallet api

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: createKey switch

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: added switch to sign and verify

Signed-off-by: Berend Sliedrecht <[email protected]>

style: added tsdoc

Signed-off-by: Berend Sliedrecht <[email protected]>

fix: remove deprecated multibase and multihash (openwallet-foundation#674)

Signed-off-by: Timo Glastra <[email protected]>
feat(crypto): add abstract KeyPair class

Signed-off-by: NB-Karim <[email protected]>

feat(crypto): add WalletKeyPair

Signed-off-by: NB-Karim <[email protected]>

style: fix formatting issues

Signed-off-by: NB-Karim <[email protected]>

feat: add dependency .d.ts files

Signed-off-by: Karim <[email protected]>

feat: implemented create key in wallet

Signed-off-by: Berend Sliedrecht <[email protected]>

Merge branch 'main' into feat/next-signatures

feat: implemented sign and verify

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: implementation done, still need record retrieval

Signed-off-by: Berend Sliedrecht <[email protected]>

fix: casing

Signed-off-by: Berend Sliedrecht <[email protected]>

refactor: remove keypairrecord and keypairrepository

Signed-off-by: Berend Sliedrecht <[email protected]>

fix: merge

Merge branch 'feat/Ed25519Signature2018' of github.com:animo/aries-framework-javascript into feat/next-signatures

Merge branch 'feat/next-signatures' of github.com:animo/aries-framework-javascript into feat/next-signatures

feat: finished without test

Signed-off-by: Berend Sliedrecht <[email protected]>

fix(routing): mediation recipient role for recipient (openwallet-foundation#661)

Signed-off-by: Timo Glastra <[email protected]>
refactor(core): renamed BufferEncoder to TypedArrayEncoder (openwallet-foundation#675)

Signed-off-by: Berend Sliedrecht <[email protected]>
feat: add Ed25519Signature2018

Signed-off-by: Karim <[email protected]>

feat: finished WalletKeyPair implementation

Signed-off-by: Karim <[email protected]>

Merge branch 'main' into feat/W3cCredentialService

Merge branch 'main' into feat/next-signatures

Merge branch 'feat/next-signatures' into feat/W3cCredentialService

fix: do not use basic message id as record id (openwallet-foundation#677)

Signed-off-by: Timo Glastra <[email protected]>
docs: inline and dev docs added

Signed-off-by: Berend Sliedrecht <[email protected]>

Merge remote-tracking branch 'origin' into feat/bbs

fix: cleanup

Signed-off-by: Berend Sliedrecht <[email protected]>

fix: using typedarrayencoder now

Signed-off-by: Berend Sliedrecht <[email protected]>

tests: started on IndyWallet test

Signed-off-by: Berend Sliedrecht <[email protected]>

tests: test sign function

Signed-off-by: Berend Sliedrecht <[email protected]>

build(deps): bump minimist from 1.2.5 to 1.2.6 (openwallet-foundation#682)

feat: improved tests

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: check if array is typedarray

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: added react native setup

Signed-off-by: Berend Sliedrecht <[email protected]>

docs: updated diff syntax

Signed-off-by: Berend Sliedrecht <[email protected]>

build(deps): bump plist from 3.0.4 to 3.0.5 (openwallet-foundation#683)

feat(routing): allow to discover mediator pickup strategy (openwallet-foundation#669)

Signed-off-by: Timo Glastra <[email protected]>
tests: test isTypedArray

Signed-off-by: Berend Sliedrecht <[email protected]>

fix: resolved feedback

Signed-off-by: Berend Sliedrecht <[email protected]>

build: decremented core build version

Signed-off-by: Berend Sliedrecht <[email protected]>

fix: update inbound message validation  (openwallet-foundation#678)

Changed isPlaintextMessage error handling, and removed logic from isEncryptedMessage
Use isValidJweStructure

Signed-off-by: Niall Shaw <[email protected]>
feat: add sign method

Signed-off-by: Karim <[email protected]>

Merge branch 'main' into feat/W3cCredentialService

feat: added w3c record and repository

Signed-off-by: Berend Sliedrecht <[email protected]>

feat: working repository and record

Signed-off-by: Berend Sliedrecht <[email protected]>

Merge pull request #17 from blu3beri/feat/w3crecord

feat(core): w3cCredentialRecord and w3cCredentialRepository
fix(core): set tags in MediationRecord constructor (openwallet-foundation#686)

Signed-off-by: Ariel Gentile <[email protected]>
Merge branch 'main' into feat/W3cCredentialService

feat: implement verifyCredential

Signed-off-by: Karim <[email protected]>

feat: createPresentation

Signed-off-by: Karim <[email protected]>

feat: implemented SignatureSuiteRegistry

Signed-off-by: Karim <[email protected]>

feat: finish signPres and verifyPres

Signed-off-by: Karim <[email protected]>

refactor: clean-up directory structure

Signed-off-by: Karim <[email protected]>

feat: add BbsBlsSiganture2020 to sig-registry

Signed-off-by: Karim <[email protected]>

Merge branch 'main' into feat/bbs

Merge branch 'feat/bbs' into feat/jsonld-credentials

feat: implement sign for bbs

Signed-off-by: Karim <[email protected]>

refactor: clean-up W3cCredentialService options

Signed-off-by: Karim <[email protected]>

refactor: switched to mattr jsonld-signatures bbs

Signed-off-by: Karim <[email protected]>

feat: regex for schemaVersion, issuerDid, credDefId, schemaId, schemaIssuerDid (openwallet-foundation#679)

Signed-off-by: annelein <[email protected]>
feat: support wallet key rotation (openwallet-foundation#672)

Signed-off-by: Mostafa <[email protected]>
feat: add role and method to did record tags (openwallet-foundation#692)

Signed-off-by: Timo Glastra <[email protected]>
feat: delete credential from wallet (openwallet-foundation#691)

Signed-off-by: Jan <[email protected]>
feat: extension module creation (openwallet-foundation#688)

Signed-off-by: Ariel Gentile <[email protected]>
refactor: restructured fixtures and more

Signed-off-by: Karim <[email protected]>

Merge branch 'main' into feat/jsonld-credentials

fix: disallow floating promises (openwallet-foundation#704)

Signed-off-by: Timo Glastra <[email protected]>
feat: bbs verification

Signed-off-by: Karim <[email protected]>

Merge branch 'main' into feat/jsonld-credentials

refactor: start and stop transports in parallel (openwallet-foundation#705)

Signed-off-by: Timo Glastra <[email protected]>
ci: add yml for postgres setup (openwallet-foundation#703)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
fix: did sov service type resolving (openwallet-foundation#689)

Signed-off-by: James Ebert <[email protected]>
test: add test assets

Signed-off-by: Karim <[email protected]>

test(vc): add caching documentLoader for tests

Signed-off-by: Karim <[email protected]>

build(deps): bump async from 2.6.3 to 2.6.4 (openwallet-foundation#710)

feat: add update assistant for storage migrations (openwallet-foundation#690)

Signed-off-by: Timo Glastra <[email protected]>
feat: support revocation notification messages (openwallet-foundation#579)

Signed-off-by: Patrick Kenyon <[email protected]>

Co-authored-by: James Ebert <[email protected]>
fix: disallow floating promises (openwallet-foundation#704)

Signed-off-by: Timo Glastra <[email protected]>
test: add test assets

Signed-off-by: Karim <[email protected]>

test(vc): add caching documentLoader for tests

Signed-off-by: Karim <[email protected]>

Merge branch 'karim/test' into feat/jsonld-credentials

refactor: start and stop transports in parallel (openwallet-foundation#705)

Signed-off-by: Timo Glastra <[email protected]>
ci: add yml for postgres setup (openwallet-foundation#703)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
fix: did sov service type resolving (openwallet-foundation#689)

Signed-off-by: James Ebert <[email protected]>
build(deps): bump async from 2.6.3 to 2.6.4 (openwallet-foundation#710)

feat: add update assistant for storage migrations (openwallet-foundation#690)

Signed-off-by: Timo Glastra <[email protected]>

feat: support revocation notification messages (openwallet-foundation#579)

Signed-off-by: Patrick Kenyon <[email protected]>

Co-authored-by: James Ebert <[email protected]>
fix: yarn.lock conflict

Merge branch 'main' into feat/jsonld-credentials

refactor: replace message type constant with string literal (openwallet-foundation#721)

Signed-off-by: Jakub Koci <[email protected]>
test: add local did fixtures

feat: add credential fetch methods

Signed-off-by: Karim <[email protected]>

feat: add react native documentLoader

Signed-off-by: Karim <[email protected]>

style: fix styling issues (eslint, ts, etc.)

Signed-off-by: Karim <[email protected]>

Merge branch 'main' into feat/jsonld-credentials
fix: allow agent without inbound endpoint to connect when using multi-use invitation (openwallet-foundation#712)

Previously the session is only stored by the connection id, but this is not always enough for the session to be reused. When using a multi-use invitation the connection id will change while processing the message, meaning the session cannot be reused. This also helps with cases where no connection is established. Fixes openwallet-foundation#483

Signed-off-by: Timo Glastra <[email protected]>
fix: close session early if no return route (openwallet-foundation#715)

This adds a `close` method to all transport sessions so it can be closed from within the agent. This allows us to close the session early if the message doesn't have return routing enabled

Signed-off-by: Timo Glastra <[email protected]>
ci: add node 18 to test matrix (openwallet-foundation#735)

Signed-off-by: Timo Glastra <[email protected]>
feat: pickup v2 protocol (openwallet-foundation#711)

Signed-off-by: KolbyRKunz <[email protected]>

BREAKING CHANGE: The mediator pickup strategy enum value `MediatorPickupStrategy.Explicit` has been renamed to `MediatorPickupStrategy.PickUpV1` to better align with the naming of the new `MediatorPickupStrategy.PickUpV2`
Merge branch 'main' into feat/jsonld-credentials

fix: dropped unused dependency

Signed-off-by: Karim <[email protected]>

fix: error typo

Co-authored-by: Timo Glastra <[email protected]>
fix: simplify keyType declaration

Co-authored-by: Timo Glastra <[email protected]>
fix: optional fields in did document (openwallet-foundation#726)

Signed-off-by: Timo Glastra <[email protected]>
fix: dropped ed25519 ctx deps

Signed-off-by: Karim <[email protected]>

fix: removed unused type def

Signed-off-by: Karim <[email protected]>

fix: remove unnecesarry transformer

Signed-off-by: Karim <[email protected]>

fix: broken import

Signed-off-by: Karim <[email protected]>

fix: remove unnecessary W3cCredentialState

Signed-off-by: Karim <[email protected]>

fix: doc typo

Co-authored-by: Timo Glastra <[email protected]>

Signed-off-by: Karim Stekelenburg <[email protected]>
fix: remove commented code

Signed-off-by: Karim <[email protected]>

fix: remove unnecessary comment

Signed-off-by: Karim <[email protected]>

fix: rename confusing context vs context url

Signed-off-by: Karim <[email protected]>

fix: moved jsonld related types and code to utils file

Signed-off-by: Karim <[email protected]>

fix: replaced inline urls with local constants

Signed-off-by: Karim <[email protected]>

fix: broken imports

Signed-off-by: Karim <[email protected]>

fix: eslint issues

Signed-off-by: Karim <[email protected]>

fix: eslint issues

Signed-off-by: Karim <[email protected]>

fix: remove unnecessary assignment

Signed-off-by: Karim <[email protected]>

fix: replace faulty challenge assignment

Signed-off-by: Karim <[email protected]>

fix: inverted statement

Signed-off-by: Karim <[email protected]>

fix: remove unused revoked options

Signed-off-by: Karim <[email protected]>

fix: uuid challenge and presentation suites

Signed-off-by: Karim <[email protected]>

test: add missing test for bbs verify pres

Signed-off-by: Karim <[email protected]>

refactor: add custom ed25519 2020 to 2018 impl

Signed-off-by: Karim <[email protected]>

fix: unclear variable name

Signed-off-by: Karim <[email protected]>

feat: add issue credential v2 (openwallet-foundation#745)

Signed-off-by: Mike Richardson <[email protected]>
fix: removed unused props from docs

Signed-off-by: Karim <[email protected]>

refactor: rename utilities.ts to bbs-utils.ts

Signed-off-by: Karim <[email protected]>

feat: add additional W3cCredentialRecord tags

Signed-off-by: Karim <[email protected]>

fix: removed duplicate function

Signed-off-by: Karim <[email protected]>

fix: do not import test logger in src (openwallet-foundation#746)

Signed-off-by: Timo Glastra <[email protected]>
fix: do not import from src dir (openwallet-foundation#748)

Signed-off-by: Timo Glastra <[email protected]>
refactor: rewrite conversion method

Signed-off-by: Karim Stekelenburg <[email protected]>

feat: add givenId as W3cCredentialRecord tag

Signed-off-by: Karim Stekelenburg <[email protected]>

fix: convert any types

Signed-off-by: Karim Stekelenburg <[email protected]>

chore!: update indy-sdk-react-native version to 0.2.0 (openwallet-foundation#754)

Signed-off-by: Amit <[email protected]>

BREAKING CHANGE: indy-sdk-react-native has been updated to 0.2.0. The new version now depends on libindy version 1.16 and requires you to update the binaries in your react-native application. See the [indy-sdk-react-native](https://github.com/hyperledger/indy-sdk-react-native) repository for instructions on how to get the latest binaries for both iOS and Android.
fix: typings

Signed-off-by: Karim Stekelenburg <[email protected]>

fix: typings

Signed-off-by: Karim <[email protected]>

fix: typings & drop jsonld bbs dep

Signed-off-by: Karim <[email protected]>

fix: remove commented code

Signed-off-by: Karim <[email protected]>

fix: typing and faulty context

Signed-off-by: Karim <[email protected]>

fix: remove keyAgreement

Signed-off-by: Karim <[email protected]>

fix: remove unused typing file

Signed-off-by: Karim <[email protected]>

fix: rename map variable

Signed-off-by: Karim <[email protected]>

fix: use w3cDate

Signed-off-by: Karim <[email protected]>

fix: rename map variable

Signed-off-by: Karim <[email protected]>

style: clean map syntax

Signed-off-by: Karim <[email protected]>

fix: typo

Signed-off-by: Karim <[email protected]>

fix: remove commented code

Signed-off-by: Karim <[email protected]>

feat(core): add support for postgres wallet type (openwallet-foundation#699)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

Co-authored-by: Timo Glastra <[email protected]>
fix: add g1 and g2 contexts

Signed-off-by: Karim <[email protected]>

fix: add X25519  contexts

Signed-off-by: Karim <[email protected]>

fix(node): allow to import node package without postgres (openwallet-foundation#757)

Signed-off-by: Timo Glastra <[email protected]>
fix: mediation record checks for pickup v2 (openwallet-foundation#736)

Signed-off-by: Timo Glastra <[email protected]>
Merge branch 'main' into feat/jsonld-credentials

fix: Key imports

Signed-off-by: Karim <[email protected]>

fix: change invalid g1 g2 contexts to bbs

Signed-off-by: Karim <[email protected]>

fix: remove invalid contexts

Signed-off-by: Karim <[email protected]>

fix: delete credentials (openwallet-foundation#766)

Signed-off-by: Mike Richardson <[email protected]>
fix: various

Signed-off-by: Karim <[email protected]>

test: do not use indy ledgers in wallet test

Signed-off-by: Timo Glastra <[email protected]>

fix: add jsonld.expand typedef

Signed-off-by: Karim <[email protected]>

Merge branch 'main' into feat/jsonld-credentials

fix: add additional typedefs

Signed-off-by: Karim <[email protected]>

feat: add out-of-band and did exchange (openwallet-foundation#717)

Signed-off-by: Jakub Koci <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>

BREAKING CHANGE: the connections module has been extended with an out of band module and support for the DID Exchange protocol. Some methods have been moved to the out of band module, see [Migrating from AFJ 0.1.0 to 0.2.x](https://github.com/hyperledger/aries-framework-javascript/blob/main/docs/migration/0.1-to-0.2.md) for detailed migration instructions.
feat: support handling messages with different minor version (openwallet-foundation#714)

Signed-off-by: Timo Glastra <[email protected]>
fix: relax validation of thread id in revocation notification (openwallet-foundation#768)

Signed-off-by: Blazej Marcinkiewicz <[email protected]>
fix: typing issues with jsonld

Signed-off-by: Timo Glastra <[email protected]>

feat: ability to add generic records (openwallet-foundation#702)

feat: extension module creation (openwallet-foundation#688)

Co-authored-by: Berend Sliedrecht <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
Merge pull request #21 from TimoGlastra/fix/jsonld-types-issues

fix: typing issues with jsonld
fix: propose payload attachment in in snake_case JSON format (openwallet-foundation#775)

Signed-off-by: Mike Richardson <[email protected]>
fix: typing issues

Signed-off-by: Karim <[email protected]>

fix: delete credentials (openwallet-foundation#770)

Signed-off-by: Mike Richardson <[email protected]>
fix: type issues

Signed-off-by: Karim <[email protected]>

test: use event listener instead of while loop (openwallet-foundation#778)

Signed-off-by: Timo Glastra <[email protected]>
feat: bbs createKey, sign and verify (openwallet-foundation#684)

Signed-off-by: Berend Sliedrecht <[email protected]>

Merge branch '0.3.0-pre' into feat/jsonld-credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiUseInvitations do not work when edge agent is connecting
3 participants