Fix zdb and inuse tests that don't pass with real disks

[PaulZ-98]

Due to zpool create auto-partioning in Linux (i.e. sdb1),
certain utilities need to use the partition (sdb1) while
others use the whole disk name (sdb).
Fixes #6939

Authored-by: Paul Zuchowski [email protected]
Signed-off-by: Paul Zuchowski [email protected]

Description

For Linux, we need to carefully choose between partition 1 of a disk (i.e. sdb1) and the whole disk when passing disk names to utilities such as zdb, parted, and dd. Also we must clear disks using parted to create a whole disk gpt label before getting into the body of some tests.

Motivation and Context

Linux zfstest zdb and inuse tests will only pass in the default DISKS setup using loop devices. Setting DISKS="sdb sdc sdd" will result in failure. These fixes enable the tests to pass using actual disks.

How Has This Been Tested?

Tested with loop devices and real disks.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commit messages are properly formatted and contain Signed-off-by.
• Change has been approved by a ZFS on Linux member.

[codecov]

Codecov Report

Merging #7261 into master will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7261      +/-   ##
==========================================
+ Coverage   76.37%   76.69%   +0.31%     
==========================================
  Files         327      327              
  Lines      103866   103866              
==========================================
+ Hits        79332    79662     +330     
+ Misses      24534    24204     -330

Flag	Coverage Δ
#kernel	76.41% <ø> (+0.44%)	⬆️
#user	66.18% <ø> (+0.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d52c3...cb2d110. Read the comment docs.

[behlendorf]

And verified locally with real disks.

--- Configuration ---
Runfile:         tests/runfiles/linux.run
STF_TOOLS:       tests/test-runner
STF_SUITE:       tests/zfs-tests
STF_PATH:        bin
FILEDIR:         /var/tmp
FILES:           /var/tmp/file-vdev0 /var/tmp/file-vdev1 /var/tmp/file-vdev2
LOOPBACKS:
DISKS:           vdb vdc vdd
NUM_DISKS:       3
FILESIZE:        4G
ITERATIONS:      1
TAGS:            zdb,inuse
Keep pool(s):    rpool
Missing util(s): pax 

tests/test-runner/bin/test-runner.py  -c tests/runfiles/linux.run -T zdb,inuse -i tests/zfs-tests -I 1
Test: tests/zfs-tests/tests/functional/cli_root/zdb/zdb_001_neg (run as root) [00:04] [PASS]
Test: tests/zfs-tests/tests/functional/cli_root/zdb/zdb_002_pos (run as root) [00:14] [PASS]
Test: tests/zfs-tests/tests/functional/cli_root/zdb/zdb_003_pos (run as root) [00:01] [PASS]
Test: tests/zfs-tests/tests/functional/cli_root/zdb/zdb_004_pos (run as root) [00:02] [PASS]
Test: tests/zfs-tests/tests/functional/cli_root/zdb/zdb_005_pos (run as root) [00:02] [PASS]
Test: tests/zfs-tests/tests/functional/cli_root/zdb/zdb_006_pos (run as root) [00:14] [PASS]
Test: tests/zfs-tests/tests/functional/inuse/setup (run as root) [00:00] [PASS]
Test: tests/zfs-tests/tests/functional/inuse/inuse_001_pos (run as root) [00:00] [SKIP]
Test: tests/zfs-tests/tests/functional/inuse/inuse_003_pos (run as root) [00:00] [SKIP]
Test: tests/zfs-tests/tests/functional/inuse/inuse_004_pos (run as root) [00:01] [PASS]
Test: tests/zfs-tests/tests/functional/inuse/inuse_005_pos (run as root) [00:33] [PASS]
Test: tests/zfs-tests/tests/functional/inuse/inuse_006_pos (run as root) [00:00] [SKIP]
Test: tests/zfs-tests/tests/functional/inuse/inuse_007_pos (run as root) [00:00] [SKIP]
Test: tests/zfs-tests/tests/functional/inuse/inuse_008_pos (run as root) [00:15] [PASS]
Test: tests/zfs-tests/tests/functional/inuse/inuse_009_pos (run as root) [00:48] [PASS]

Results Summary
SKIP       4
PASS      11

Running Time:   00:02:20
Percent passed: 73.3%