Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubebuilder to v4 #346

Conversation

@Neo2308 Neo2308 force-pushed the feature/main/bump-kubebuilder-v4 branch from 4d76fbd to c0f6bba Compare June 18, 2024 07:50
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024
@Neo2308 Neo2308 force-pushed the feature/main/bump-kubebuilder-v4 branch from 65bf52b to 193ecbd Compare July 25, 2024 06:35
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.01%. Comparing base (08ab7fb) to head (06c06d5).
Report is 35 commits behind head on main.

Files Patch % Lines
pkg/plugins/util/helpers.go 50.00% 2 Missing ⚠️
pkg/plugins/helm/v1/api.go 0.00% 1 Missing ⚠️
pkg/plugins/helm/v1/init.go 0.00% 1 Missing ⚠️
pkg/plugins/hybrid/v1alpha/init.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (06c06d5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ab7fb) HEAD (06c06d5)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #346       +/-   ##
===========================================
- Coverage   85.06%   52.01%   -33.06%     
===========================================
  Files          19       66       +47     
  Lines        1346     3232     +1886     
===========================================
+ Hits         1145     1681      +536     
- Misses        125     1448     +1323     
- Partials       76      103       +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2024
* Bump kubebuilder v3 -> v4.
* Add copy of helper functions which were removed upstream
* Remove kube-rbac-proxy.
* Remove component config support.
* Regenerate test-data
* Updated spacing in markers to be consistent ("//+" -> "// +")
@Neo2308 Neo2308 force-pushed the feature/main/bump-kubebuilder-v4 branch from 193ecbd to 06c06d5 Compare August 9, 2024 10:59
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2024
@Neo2308
Copy link
Author

Neo2308 commented Aug 20, 2024

@acornett21 / @joelanford need help with this PR. How can we resolve the go-apidiff job failures?

@acornett21
Copy link
Contributor

Hi @Neo2308 please see my comment on this other PR.

#377 (comment)

@acornett21
Copy link
Contributor

This is no longer needed...closing.

@acornett21 acornett21 closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants