Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/plugins/ansible: manager scaffolding updates for --metrics-addr and envvars #3570

Merged
merged 2 commits into from
Jul 27, 2020
Merged

internal/plugins/ansible: manager scaffolding updates for --metrics-addr and envvars #3570

merged 2 commits into from
Jul 27, 2020

Conversation

joelanford
Copy link
Member

Description of the change:

  • Remove scaffolding of POD_NAME and WATCH_NAMESPACE
  • Use default --metrics-addr flag when auth proxy is not in use

Motivation for the change:
Closes #3567 and #3569

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@joelanford joelanford mentioned this pull request Jul 27, 2020
Closed
92 tasks
camilamacedo86
camilamacedo86 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

After pass in the CI

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
jmrodri
jmrodri approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
hasbro17
hasbro17 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelanford joelanford merged commit ad2759e into operator-framework:master Jul 27, 2020
@joelanford joelanford deleted the ansible-metrics-addr branch July 27, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees

@jmrodri jmrodri

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible plugin is scaffolding manager with WATCH_NAMESPACE and POD_NAME env vars
5 participants
@joelanford @jmrodri @hasbro17 @camilamacedo86 @openshift-ci-robot