Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[50953] Progress reporting for work package hierarchies: Change calculation and name of Work and Remaining work #14216

Merged
merged 8 commits into from
Jan 10, 2024
Merged

[50953] Progress reporting for work package hierarchies: Change calculation and name of Work and Remaining work #14216

merged 8 commits into from
Jan 10, 2024

Commits on Jan 9, 2024

  1. [50963] Update derived work and remaining work in a migration

    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    1ef2568 View commit details
    Browse the repository at this point in the history

  2. Introduce let_work_packages helpers 

    It allows to declare work packages and their properties from a visual
table. It is especially useful to visualize hierarchies and data as if
it were presented in the work package table page in OpenProject app.
    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d044c90 View commit details
    Browse the repository at this point in the history

  3. Capitalize some column names in wp table configuration dropdown 

    For consistency because all other options are capitalized.
    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0acbd07 View commit details
    Browse the repository at this point in the history

  4. Use accessible selector for checking column header presence 

    It allows removing the `finicky` flag from the `add` method.

FWIW the `have_link` only works if the `a` tag has a `href` attribute,
and some column headers like "Overall costs" did not have it, which is
why another way of selecting them was needed. With the `:columnheader`
selector, it works fine and reads better.
    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    a4d1f3e View commit details
    Browse the repository at this point in the history

  5. Add remaining work column to work package index sums test 

    Also rewrote parts of the test to fix rubocop issues and make assertions
more expressive.
    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    43283bc View commit details
    Browse the repository at this point in the history

  6. [50962] Add feature test for query sums with filters

    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    2bb40dc View commit details
    Browse the repository at this point in the history

  7. Replace build_work_package_hierarchy with let_work_packages

    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d230fcd View commit details
    Browse the repository at this point in the history

  8. Display estimated time correctly in wiki macro 

    For instance with the following wiki text: "Current estimates: workPackageValue:1234:estimatedTime".
    @cbliard
    cbliard committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d4f6361 View commit details
    Browse the repository at this point in the history