[50953] Progress reporting for work package hierarchies: Change calculation and name of Work and Remaining work #14216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
from
380119e
to
5a4f2b2
Compare
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
2 times, most recently
from
9ffdf64
to
73336f6
Compare
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
from
5f52f15
to
ded6313
Compare
|
Removing and readding pullpreview tag to trigger a fresh pullpreview. Previous one was failing due to inability to download googleauth gem as version 1.9.0 has been yanked. It should work now that version has been updated to 1.9.1. |
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
from
76f5e4d
to
af24873
Compare
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
4 times, most recently
from
bd74da2
to
0f5bd78
Compare
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
from
40a5526
to
a65daab
Compare
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
3 times, most recently
from
384511e
to
070b68c
Compare
cbliard
changed the title
It allows to declare work packages and their properties from a visual table. It is especially useful to visualize hierarchies and data as if it were presented in the work package table page in OpenProject app.
For consistency because all other options are capitalized.
It allows removing the `finicky` flag from the `add` method. FWIW the `have_link` only works if the `a` tag has a `href` attribute, and some column headers like "Overall costs" did not have it, which is why another way of selecting them was needed. With the `:columnheader` selector, it works fine and reads better.
Also rewrote parts of the test to fix rubocop issues and make assertions more expressive.
For instance with the following wiki text: "Current estimates: workPackageValue:1234:estimatedTime".
cbliard
force-pushed
the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
from
070b68c
to
d4f6361
Compare
|
|
||
| def read_and_update_work_packages_data(work_packages_data) | ||
| work_packages_data.each do |work_package_data| | ||
| work_package_data => { attributes:, row: } |
There was a problem hiding this comment.
I had to look up what this does. Very cool that it works somewhat like a Hash destructuring.
There was a problem hiding this comment.
pattern matching. I'm still not sure if I like it or not, so I try using it from times to times to get a better feeling about it.
| symbolic_name = name.to_sym | ||
| return symbolic_name if @work_packages_by_identifier.has_key?(symbolic_name) | ||
|
|
||
| spell_checker = DidYouMean::SpellChecker.new(dictionary: @work_packages_by_identifier.keys.map(&:to_s)) |
There was a problem hiding this comment.
I've always been curious how this is done, cool!
aaron-contreras
approved these changes
Jan 9, 2024
cbliard
deleted the
epic/40867-progress-reporting-for-work-package-hierarchies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: https://community.openproject.org/wp/40867
Feature: https://community.openproject.org/wp/50953
This PR is for the feature and will be frequently rebased onto
devas the more specialized PR are merged.Pull requests: