[50961] Ensure computation of the derived values is triggered at the right time #14516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly generated by GitHub Copilot.
Add tests to ensure that the work and remaining work derived values are computed again when: - a child work package work or remaining work value is changed - a child work package is deleted More tests to need to be added
- Add optional label to context menu. - Add menuitem and separator role attribute to context menu items. - Use capybara accessible selectors to interact with them in tests. - Harmonize `#expect_options` and `#expect_no_options` argument type.
Setting `intervals` in Retriable configuration overrides `tries`,
`base_interval`, `max_interval`, `rand_factor`, and `multiplier`
parameters and thus ruins the benefit of calling `retry_block` with
`args: { tries: _ }` argument.
Prefer setting `base_interval`, `max_interval`, `rand_factor`, and
`multiplier` instead to keep the benefit of `args: { tries: _ }`
argument.
This will generate the following intervals: [0.5, 0.75, 1.125, ~1.7, ~2.5, ~3.8, ...]
Also improve logged messages of `retry_block`.
7 tasks
cbliard
force-pushed
the
implementation/50961-ensure-computation-of-the-derived-values-is-triggered-at-the-right-time
branch
from
04a62e3
to
c559de0
Compare
…e-derived-values-is-triggered-at-the-right-time
aaron-contreras
approved these changes
Jan 9, 2024
cbliard
deleted the
implementation/50961-ensure-computation-of-the-derived-values-is-triggered-at-the-right-time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/wp/50961
The following triggers where missing to trigger a recalculation of the derived values: