Refactor/logging #519
Merged
Refactor/logging #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…toring iteration, step and problem information
* move base data classes for dict and tuple like access to optimagic.typing * make all dataclasses frozen
* implement SQLiteLogger * expose primary_key property in AbstractKeyValueStore * add optimization type enum * improve type hints
schroedk
force-pushed
the
refactor/logging
branch
from
25546c5
to
8c88dfa
Compare
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.5.0 #519 +/- ##
==========================================
+ Coverage 90.71% 90.90% +0.18%
==========================================
Files 106 107 +1
Lines 10364 10644 +280
==========================================
+ Hits 9402 9676 +274
- Misses 962 968 +6 ☔ View full report in Codecov by Sentry. |
… argument to None
* improve existence handling * move RobustPickler * remove obsolete code * fix usage in depending subpackages
* add NonUpdatableKeyValueStore, raises exception when try to call update * split hierarchy into updatable and nonupdatable stores * make IterationStore nonupdatable
…move obsolete submodule
* move store implementation to logging.sqlalchemy, remove dependency to SQLiteConfig * move SQLiteConfig to logging.logger * remove obsolete file logging.sqlite * rename test files to mirror subpackage structure
janosg
reviewed
Aug 14, 2024
…rations from reader
…ing db file at init.
* split Logger into LogStore for writing and LogReader for reading * add new abstraction LogOptions
Done |
janosg
reviewed
Aug 19, 2024
…ze, estimate_ml, estimate_msm
janosg
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed logging is described here.
This refactoring introduces the following abstractions:
LogOptions(implementationSQLiteLogOptions), configurationLogStore(implementation_SQLiteLogStore, not exposed), write accessLogReader(implementationSQLiteLogReader), read accessThe old class
OptimizationLogReaderredirects toSQLiteLogReaderin a backward-compatible way.