Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/logging #519

Merged
merged 59 commits into from
Aug 19, 2024
Merged

Refactor/logging #519

merged 59 commits into from
Aug 19, 2024

Commits on Aug 9, 2024

  1. Add simple wrapper abstractions for logging tables

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9a95f92 View commit details
    Browse the repository at this point in the history

  2. Add abstraction of a key value store, which serves as interface for s… 

    …toring iteration, step and problem information
    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1fc3eb9 View commit details
    Browse the repository at this point in the history

  3. Add type definitions to describe iteration, step and problem information

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ccb46f2 View commit details
    Browse the repository at this point in the history

  4. Implement a sqlalchemy table acting as a KeyValueStore

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    4f59893 View commit details
    Browse the repository at this point in the history

  5. Add sqlite implementations for iteration, step and problem store

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    12c03fb View commit details
    Browse the repository at this point in the history

  6. Add tests for sqlite implementations

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d8075de View commit details
    Browse the repository at this point in the history

  7. Remove obsolete file

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3a8493f View commit details
    Browse the repository at this point in the history

  8. Refactor logging types: 

    * move base data classes for dict and tuple like access to optimagic.typing
* make all dataclasses frozen
    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a38243c View commit details
    Browse the repository at this point in the history

  9. Add bound to TyepVar, remove type:ignore

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    eb1cfc8 View commit details
    Browse the repository at this point in the history

  10. Add Logger class: 

    * implement SQLiteLogger
* expose primary_key property in AbstractKeyValueStore
* add optimization type enum
* improve type hints
    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    56364e2 View commit details
    Browse the repository at this point in the history

  11. Deprecate OptimieLogReader and redirect to SQLiteLogger

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    07ba628 View commit details
    Browse the repository at this point in the history

  12. Adapt read tests for logging to new SQLiteLogger

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8c88dfa View commit details
    Browse the repository at this point in the history

  13. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    dee344c View commit details
    Browse the repository at this point in the history

  14. Remove obsolete type cast

    @schroedk
    schroedk committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    afd0795 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Update environment files to include sqlalchemy-stubs

    @schroedk
    schroedk committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    3d7f89a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/0.5.0' into refactor/logging

    @schroedk
    schroedk committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    aadea23 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Move OptimizationStrategy type from logging.types to typing

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0474e63 View commit details
    Browse the repository at this point in the history

  2. Deprecate log_options in estimate_ml and estimate_msm, change default… 

    … argument to None
    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    79e213c View commit details
    Browse the repository at this point in the history

  3. Add functionality to handle deprecated parameter log_options

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    f034d2e View commit details
    Browse the repository at this point in the history

  4. Delet obsolete files

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ba67eaa View commit details
    Browse the repository at this point in the history

  5. Refactor logging subpackage: 

    * improve existence handling
* move RobustPickler
* remove obsolete code
* fix usage in depending subpackages
    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3c2b24d View commit details
    Browse the repository at this point in the history

  6. Rename AbstractKeyValueStore to KeyValueStore

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    c57edf0 View commit details
    Browse the repository at this point in the history

  7. Refactor logging: 

    * add NonUpdatableKeyValueStore, raises exception when try to call update
* split hierarchy into updatable and nonupdatable stores
* make IterationStore nonupdatable
    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    64082f6 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/0.5.0' into refactor/logging

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a912d3e View commit details
    Browse the repository at this point in the history

  9. Move util functions from logging submodule to optimagic.utilities, re… 

    …move obsolete submodule
    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    164d35a View commit details
    Browse the repository at this point in the history

  10. Fix issue in handling existing database file

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    911dbcc View commit details
    Browse the repository at this point in the history

  11. A docstrings to dataclasses and enumerations in logging.types

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a8570cd View commit details
    Browse the repository at this point in the history

  12. Rename KeyValueStore -> _KeyValueStore, add docstrings

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4a83de3 View commit details
    Browse the repository at this point in the history

  13. Add docstrings to Logger classes

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b792592 View commit details
    Browse the repository at this point in the history

  14. Add docstrings to logger.sqlalchemy submodule

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    7e29fe2 View commit details
    Browse the repository at this point in the history

  15. Add docstrings to logger.sqlite submodule

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    6447d1a View commit details
    Browse the repository at this point in the history

  16. Improve argument description of fast_logging

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4b005eb View commit details
    Browse the repository at this point in the history

  17. Set default argument for fast_logging to False

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1f77ce8 View commit details
    Browse the repository at this point in the history

  18. Import SQLiteLogger and ExistenceStrategy on top level of logging module

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4796604 View commit details
    Browse the repository at this point in the history

  19. Adpat how-to-guide for logging

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    74c61d4 View commit details
    Browse the repository at this point in the history

  20. Improve ValueError message for logging types

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0930bd5 View commit details
    Browse the repository at this point in the history

  21. Fix issue in create_engine method, due to not overriding correctly

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1449d30 View commit details
    Browse the repository at this point in the history

  22. Raise warning in case table exists and if_table_exists="replace"

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    365ed94 View commit details
    Browse the repository at this point in the history

  23. Increase test coverage

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ba3a9df View commit details
    Browse the repository at this point in the history

  24. Refactor logging package: 

    * move store implementation to logging.sqlalchemy, remove dependency to SQLiteConfig
* move SQLiteConfig to logging.logger
* remove obsolete file logging.sqlite
* rename test files to mirror subpackage structure
    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3c332ce View commit details
    Browse the repository at this point in the history

  25. Fix an issue in replacing the database file on windows, due to Permis… 

    …sionError
    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3dc7a05 View commit details
    Browse the repository at this point in the history

  26. Switch order of file removal and warning in try block

    @schroedk
    schroedk committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1b4110d View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Move history return types to optimagic.typing

    @schroedk
    schroedk committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    ce504c1 View commit details
    Browse the repository at this point in the history

  2. Do not store flattened pytrees in logger stores, remove unflatten ope… 

    …rations from reader
    @schroedk
    schroedk committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d98c240 View commit details
    Browse the repository at this point in the history

  3. Raise ValueError instead of warning in handling og deprecated log_opt… 

    …ions
    @schroedk
    schroedk committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    462e7a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2024

  1. Move metadate creation from init to cached property, due to not creat… 

    …ing db file at init.
    @schroedk
    schroedk committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    a67035f View commit details
    Browse the repository at this point in the history

  2. Refactor logging subpackage: 

    * split Logger into LogStore for writing and LogReader for reading
* add new abstraction LogOptions
    @schroedk
    schroedk committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    5634837 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Improve docstrings and type annotations

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    142060b View commit details
    Browse the repository at this point in the history

  2. Fix test to catch a warning

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6366692 View commit details
    Browse the repository at this point in the history

  3. Adapt documentation for logging

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    dade965 View commit details
    Browse the repository at this point in the history

  4. Add reader creation from path to documentation

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bfb2dcc View commit details
    Browse the repository at this point in the history

  5. Remove method 'from_path' from SQLiteLogReader, remove 'as_reader' fr… 

    …om LogStore
    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d6f2c62 View commit details
    Browse the repository at this point in the history

  6. Improve future warning for log options handling

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    620a62e View commit details
    Browse the repository at this point in the history

  7. Extend CHANGES.md

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a612912 View commit details
    Browse the repository at this point in the history

  8. Rename CriterionEvaluationResult -> IterationState

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3668e58 View commit details
    Browse the repository at this point in the history

  9. Raise FileNotFoundError for SQLiteLogReader in case no db file found

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4eb9032 View commit details
    Browse the repository at this point in the history

  10. Add tests for covering deprecation of log_options in minimize, maximi… 

    …ze, estimate_ml, estimate_msm
    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a7d3eaa View commit details
    Browse the repository at this point in the history

  11. Add test for dprecated OptimizationLogReader

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    cf6f0b9 View commit details
    Browse the repository at this point in the history

  12. Fix broken test

    @schroedk
    schroedk committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3d815fc View commit details
    Browse the repository at this point in the history