Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-8940] Correct return type hints #265

Merged
merged 5 commits into from
Mar 28, 2023
Merged

[FSSDK-8940] Correct return type hints #265

merged 5 commits into from
Mar 28, 2023

Conversation

rafinutshaw-optimizely
Copy link
Contributor

@rafinutshaw-optimizely rafinutshaw-optimizely commented Mar 27, 2023 •
edited
Loading

Summary

  • Check if testcases pass after fixing the hints as suggested in the PRs of the issue

Test plan

  • No changes here

Issues

@rafinutshaw-optimizely rafinutshaw-optimizely requested a review from a team as a code owner March 27, 2023 19:55
@rafinutshaw-optimizely rafinutshaw-optimizely changed the title Add mixed return type to jsonserialize [FSSDK-8940] Add mixed return type to jsonserialize Mar 27, 2023
mikechu-optimizely
mikechu-optimizely requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review about copyright notices.

src/Optimizely/OptimizelyUserContext.php Show resolved Hide resolved
src/Optimizely/UserProfile/UserProfileServiceInterface.php Show resolved Hide resolved
@mikechu-optimizely
Copy link
Contributor

This PR once merged and released should resolve: #250, #254, & #259

@mikechu-optimizely mikechu-optimizely changed the title [FSSDK-8940] Add mixed return type to jsonserialize [FSSDK-8940] Correct return type hints Mar 27, 2023
@coveralls
Copy link

coveralls commented Mar 27, 2023 •
edited
Loading

Coverage Status

Coverage: 97.149% (+0.06%) from 97.092% when pulling 0197745 on utshaw/php-8.2 into 34bebf0 on master.

mikechu-optimizely
mikechu-optimizely approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rafinutshaw-optimizely rafinutshaw-optimizely merged commit e025f61 into master Mar 28, 2023
@rafinutshaw-optimizely rafinutshaw-optimizely deleted the utshaw/php-8.2 branch March 28, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@rafinutshaw-optimizely rafinutshaw-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafinutshaw-optimizely @mikechu-optimizely @coveralls