Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-8940] Correct return type hints #265

Merged
merged 5 commits into from
Mar 28, 2023
Merged

[FSSDK-8940] Correct return type hints #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a77625
Add mixed return type to jsonserialize
rafinutshaw-optimizely Mar 27, 2023
78dd549
Add test for 8.2
rafinutshaw-optimizely Mar 27, 2023
0bb1188
Rollback 8.2 tests and add suggested comments
rafinutshaw-optimizely Mar 27, 2023
541d702
Fix comment
rafinutshaw-optimizely Mar 27, 2023
0197745
Update copyright
rafinutshaw-optimizely Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Optimizely/OptimizelyUserContext.php
View file
Open in desktop
rafinutshaw-optimizely marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Copyright 2021-2022, Optimizely
* Copyright 2021-2023, Optimizely
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -147,6 +147,9 @@ public function getOptimizely()
return $this->optimizelyClient;
}

/**
* @return mixed
*/
#[\ReturnTypeWillChange]
public function jsonSerialize()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Optimizely/UserProfile/UserProfileServiceInterface.php
View file
Open in desktop
rafinutshaw-optimizely marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Copyright 2017, Optimizely Inc, and Contributors
* Copyright 2017, 2023, Optimizely Inc, and Contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -23,7 +23,7 @@ interface UserProfileServiceInterface
*
* @param $userId string The ID of the user whose profile will be retrieved.
*
* @return userProfile array The user profile.
* @return array The user profile.
*/
public function lookup($userId);

Expand Down