Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for deleting manifests #48

Merged
merged 1 commit into from
Dec 12, 2022
Merged

test: add unit tests for deleting manifests #48

merged 1 commit into from
Dec 12, 2022

Conversation

wangxiaoxuan273
Copy link

@wangxiaoxuan273 wangxiaoxuan273 commented Dec 12, 2022

Artifact deletion is enabled already due to the way distribution implements ManifestService. This pr implements the missing unit tests to verify this. A future pr will implement deleting referrers.

Test on terminal: delete an OCI image manifest
image

Test on terminal: delete an OCI artifact manifest
image

Part 1 of #37

Signed-off-by: wangxiaoxuan273 [email protected]

Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 884c54b into oras-project:main Dec 12, 2022
@wangxiaoxuan273 wangxiaoxuan273 deleted the delete branch December 12, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants