Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests for deleting manifests #48

Merged
merged 1 commit into from
Dec 12, 2022
Merged

test: add unit tests for deleting manifests #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions registry/storage/manifeststore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,63 @@ func testOCIManifestStorage(t *testing.T, testname string, includeMediaTypes boo
t.Fatalf("%s: unexpected MediaType for index payload, %s", testname, payloadMediaType)
}

// Test deleting the manifest
err = ms.Delete(ctx, manifestDigest)
if err != nil {
t.Fatalf("unexpected an error deleting manifest by digest: %v", err)
}

exists, err := ms.Exists(ctx, manifestDigest)
if err != nil {
t.Fatalf("Error querying manifest existence")
}
if exists {
t.Errorf("Deleted manifest should not exist")
}

deletedManifest, err := ms.Get(ctx, manifestDigest)
if err == nil {
t.Errorf("Unexpected success getting deleted manifest")
}
switch err.(type) {
case distribution.ErrManifestUnknownRevision:
break
default:
t.Errorf("Unexpected error getting deleted manifest: %s", reflect.ValueOf(err).Type())
}

if deletedManifest != nil {
t.Errorf("Deleted manifest get returned non-nil")
}

// test deleting the index
err = ms.Delete(ctx, indexDigest)
if err != nil {
t.Fatalf("unexpected an error deleting manifest by digest: %v", err)
}

exists, err = ms.Exists(ctx, indexDigest)
if err != nil {
t.Fatalf("Error querying manifest existence")
}
if exists {
t.Errorf("Deleted manifest should not exist")
}

deletedIndex, err := ms.Get(ctx, indexDigest)
if err == nil {
t.Errorf("Unexpected success getting deleted manifest")
}
switch err.(type) {
case distribution.ErrManifestUnknownRevision:
break
default:
t.Errorf("Unexpected error getting deleted manifest: %s", reflect.ValueOf(err).Type())
}

if deletedIndex != nil {
t.Errorf("Deleted manifest get returned non-nil")
}
}

func TestOCIArtifactManifestStorage(t *testing.T) {
Expand Down Expand Up @@ -622,6 +679,35 @@ func TestOCIArtifactManifestStorage(t *testing.T) {
if payloadMediaType != v1.MediaTypeArtifactManifest {
t.Fatalf("unexpected MediaType for manifest payload, %s", payloadMediaType)
}

// Test deleting the manifest
err = ms.Delete(ctx, manifestDigest)
if err != nil {
t.Fatalf("unexpected an error deleting manifest by digest: %v", err)
}

exists, err := ms.Exists(ctx, manifestDigest)
if err != nil {
t.Fatalf("Error querying manifest existence")
}
if exists {
t.Errorf("Deleted manifest should not exist")
}

deletedManifest, err := ms.Get(ctx, manifestDigest)
if err == nil {
t.Errorf("Unexpected success getting deleted manifest")
}
switch err.(type) {
case distribution.ErrManifestUnknownRevision:
break
default:
t.Errorf("Unexpected error getting deleted manifest: %s", reflect.ValueOf(err).Type())
}

if deletedManifest != nil {
t.Errorf("Deleted manifest get returned non-nil")
}
}

// TestLinkPathFuncs ensures that the link path functions behavior are locked
Expand Down