-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document ttl for api keys #1899
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change, otherwise top :)
3. Enter the API Key name and click **Create** | ||
4. Copy the created API Key | ||
3. Enter the API Key name | ||
4. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. | |
4. Select an **expiration** date. It is recommended to always create API keys with an expiry date. |
5. Enter the API Key name and click **Create new API key**. | ||
6. Copy the created API Key from the prompt that shows at the bottom right of the screen. | ||
5. Enter the API Key name | ||
6. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. | |
6. Select an **expiration** date. It is recommended to always create API keys with an expiry date. |
3. Enter the API Key name and click **Create** | ||
4. Copy the created API Key | ||
3. Enter the API Key name | ||
4. Select an **expiration** date. Note that it is not recommeded to create API keys without an expiry date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this recommendation. Expiring API keys are a recipe for outages 😆 . Also typo in recommended
Related Issue or Design Document
https://github.com/ory-corp/cloud/pull/7011
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
Further comments