Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: document ttl for api keys #1899
base: master
Are you sure you want to change the base?
feat: document ttl for api keys #1899
Changes from 1 commit
224ff53
93fbd8c
1f37e37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 41 in docs/concepts/personal-access-token.mdx
GitHub Actions / misspell
[misspell] docs/concepts/personal-access-token.mdx#L41
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this recommendation. Expiring API keys are a recipe for outages 😆 . Also typo in
recommended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fixed by @vinckr :D.
Do you have an alternative suggestion regarding our wording here? Long-living access tokens are also a security threat, but too short-lived keys are a threat for expiring too soon, creating outages.
Check warning on line 103 in docs/concepts/personal-access-token.mdx
GitHub Actions / misspell
[misspell] docs/concepts/personal-access-token.mdx#L103
Raw output