Conflicting message IDs for node and verification

[jstsddg]

Preflight checklist

• I could not find a solution in the existing issues, docs, nor discussions.
• I agree to follow this project's Code of Conduct.
• I have read and am following this repository's Contribution Guidelines.
• This issue affects my Ory Cloud project.
• I have joined the Ory Community Slack.
• I am signed up to the Ory Security Patch Newsletter.

Describe the bug

The message IDs in the files text/message_verification.go and text/message_node.go start at the same ID 1070000, hence there are conflicting IDs. This causes a problem when implementing custom translations in the self-service UI, because messages can not identified uniquely.

See:

• kratos/text/message_node.go

  Line 4 in fc17cf8

  InfoNodeLabel ID = 1070000 + iota // 1070000

• kratos/text/message_verification.go

  Line 9 in a307deb

  InfoSelfServiceVerification ID = 1070000 + iota // 1070000

Reproducing the bug

No specific steps are needed.

Relevant log output

No response

Relevant configuration

No response

Version

v0.8.0-alpha.3 (master)

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

[aeneasr]

Nice find, would you be open for a fix?

[jstsddg]

Yes I can do that, I would suggest updating text/message_node.go to 1080000 as this ID range seems to be unused. Do you know of any side effects this change could have? Or can the starting ID simply be updated?

[aeneasr]

It can be updated, but we will need to document this as a breaking change!

[zepatrik]

The referenced commit does not actually solve this problem but a different one with duplicate IDs.

[aeneasr]

my bad