fix: de-duplicate message IDs #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
commented
Nov 22, 2021
| clidoc . | ||
| .PHONY: docs/cli | ||
| docs/cli: | ||
| go run ./cmd/clidoc/. . |
There was a problem hiding this comment.
This is way easier to manage rebuilding when needed.
| for _, spec := range decl.Specs { | ||
| value := spec.(*ast.ValueSpec) // safe because decl.Tok is token.CONST | ||
| if t, ok := value.Type.(*ast.Ident); ok { | ||
| if t.Name == "ID" { |
There was a problem hiding this comment.
This filters to use const's only of type ID (i.e. hard-coded).
| allFiles = append(allFiles, f) | ||
| } | ||
| } | ||
| _, err = (&types.Config{Importer: importer.Default()}).Check("text", set, allFiles, info) |
There was a problem hiding this comment.
This gave me a bit of a hard time, as I could not get it to properly resolve imports from modules. Therefore, the warning in the id.go file.
Comment on lines
+3
to
+4
| // This file MUST not have any imports to modules that are not in the standard library. | ||
| // Otherwise, `make docs/cli` will fail. |
| } | ||
| allFiles := make([]*ast.File, 0) | ||
| for fn, f := range pack.Files { | ||
| if strings.HasSuffix(fn, "/id.go") { |
There was a problem hiding this comment.
and hence we only load that file (hard-coded).
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
Co-authored-by: hackerman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
closes #1956
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
The clidoc util now ensures that there are no duplicate IDs.
It works, as before changing the ID I got this error: