-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade guide 0.5->0.8 #2132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2132 +/- ##
==========================================
+ Coverage 75.21% 75.23% +0.01%
==========================================
Files 293 293
Lines 15609 15600 -9
==========================================
- Hits 11741 11736 -5
+ Misses 3033 3031 -2
+ Partials 835 833 -2
Continue to review full report at Codecov.
|
First push was very low quality, should have been a draft PR 🙈. I addressed your feedback, thanks for the pointers. I am at a point now where I feel it is ready to be looked at again. |
Deleted UPGRADE.md and addressed the other feedback 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @vinckr ! The plan is 👍
@vinckr could you do this for the other projects as well? |
On the list 👍 |
As suggested in
#2104
this
I thought it makes more sense there, since it is not a very common occurance and the guide is not very extensive (yet).
I had trouble recreating a proper upgrade scenario to test everything using the quickstart or my own deployment, so I am hoping from some input.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments