Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links API doc" #2296

Merged
merged 2 commits into from
Mar 11, 2022
Merged

docs: fix broken links API doc" #2296

merged 2 commits into from
Mar 11, 2022

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Mar 10, 2022

  • fix: broken links API spec
  • fix: broken links handler.go
  • fix: broken links api.go

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@vinckr
Copy link
Member Author

vinckr commented Mar 10, 2022

Actually fixing #2295 now :).

Not sure if the changes in api_v0alpha2.go are needed, is exactly the same as in handler.go

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2296 (ff95b74) into master (e1e7516) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2296   +/-   ##
=======================================
  Coverage   76.56%   76.56%           
=======================================
  Files         318      318           
  Lines       17148    17148           
=======================================
  Hits        13129    13129           
  Misses       3087     3087           
  Partials      932      932           
Impacted Files Coverage Δ
selfservice/flow/recovery/handler.go 61.81% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e7516...ff95b74. Read the comment docs.

@aeneasr aeneasr self-assigned this Mar 11, 2022
@aeneasr aeneasr merged commit 47eaae5 into ory:master Mar 11, 2022
@vinckr vinckr deleted the vinckr-fix branch March 11, 2022 09:03
@vinckr vinckr mentioned this pull request Mar 18, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants