fix: add identity_id index to identity_verifiable_addresses table
#2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2147 +/- ##
==========================================
- Coverage 75.24% 75.21% -0.03%
==========================================
Files 294 294
Lines 15614 15614
==========================================
- Hits 11748 11744 -4
- Misses 3032 3035 +3
- Partials 834 835 +1
Continue to review full report at Codecov.
|
aeneasr
approved these changes
Jan 14, 2022
This was referenced Mar 9, 2022
Merged
7 tasks
peturgeorgievv
pushed a commit
to senteca/kratos-fork
that referenced
this pull request
Jun 30, 2023
…ory#2147) The verifiable addresses are loaded eagerly into the identity. When that happens, the `identity_verifiable_addresses` table is queried by `nid` and `identity_id`. This index should greatly improve performance, especially of the `/sessions/whoami` endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
The verifiable addresses are loaded eagerly into the identity. When that happens, the
identity_verifiable_addressestable is queried bynidandidentity_id. This index should greatly improve performance, especially of the/sessions/whoamiendpoint.