Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quickstart standalone service definition #2149

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

spacemeld
Copy link
Contributor

This change updates the service definition for the kratos-selfservice-ui-node container found in ./quickstart-standalone.yml. The docker-compose command will fail due to the invalid yaml configuration.

I was following the steps in the Quickstart section for Ory Kratos using macOS. The set of docker containers will not run as instructed without this fix.

This bug was introduced with this change.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2022

CLA assistant check
All committers have signed the CLA.

@aeneasr
Copy link
Member

aeneasr commented Jan 15, 2022

Thank you!

@aeneasr aeneasr merged commit 872b06e into ory:master Jan 15, 2022
@vinckr
Copy link
Member

vinckr commented Jan 17, 2022

Hello @spacemeld
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants