Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore whitespace around identifier with password strategy #2160

Merged
merged 2 commits into from
Jan 19, 2022
Merged

fix: Ignore whitespace around identifier with password strategy #2160

merged 2 commits into from
Jan 19, 2022

Conversation

meyfa
Copy link
Contributor

@meyfa meyfa commented Jan 18, 2022 •
edited by zepatrik
Loading

All identifiers are trimmed before they are passed to the database.

Related issue(s)

closes #2158

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

zepatrik
zepatrik requested changes Jan 19, 2022
View reviewed changes
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks very good already. Just some minor test improvements and we should be ready to go 😉

selfservice/strategy/password/login_test.go Outdated Show resolved Hide resolved
selfservice/strategy/password/registration_test.go Show resolved Hide resolved
@aeneasr aeneasr merged commit 45335c5 into ory:master Jan 19, 2022
@meyfa meyfa deleted the fix-2158 branch January 19, 2022 12:23
This was referenced Mar 9, 2022
Merged
Merged
@vinckr vinckr mentioned this pull request Mar 18, 2022
Merged
@vinckr vinckr mentioned this pull request Apr 22, 2022
Merged
7 tasks
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@meyfa
fix: ignore whitespace around identifier with password strategy (ory#…
65d28c8 
…2160)

Closes ory#2158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

@zepatrik zepatrik zepatrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email address with leading/trailing whitespace treated as different identifier
3 participants
@meyfa @aeneasr @zepatrik