Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect makefile rule #2222

Merged
merged 16 commits into from
Feb 14, 2022
Merged

fix: incorrect makefile rule #2222

merged 16 commits into from
Feb 14, 2022

Conversation

icyphox
Copy link
Contributor

@icyphox icyphox commented Feb 14, 2022

No description provided.

aeneasr
aeneasr reviewed Feb 14, 2022
View reviewed changes
Makefile Outdated
@@ -130,7 +125,7 @@ quickstart-dev:

# Formats the code
.PHONY: format
format: .bin/goimports docs/node_modules node_modules
format: .bin/goimports node_modules
goimports -w -local github.com/ory .
cd docs; npm run format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wops. Fixed.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #2222 (e09d481) into v0.8 (a1ada22) will increase coverage by 0.55%.
The diff coverage is 93.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.8    #2222      +/-   ##
==========================================
+ Coverage   75.33%   75.88%   +0.55%     
==========================================
  Files         294      297       +3     
  Lines       15651    15905     +254     
==========================================
+ Hits        11791    12070     +279     
+ Misses       3029     2977      -52     
- Partials      831      858      +27
Impacted Files Coverage Δ
cmd/daemon/serve.go 82.75% <50.00%> (+0.20%) ⬆️
courier/template/load_template.go 78.43% <86.53%> (+11.76%) ⬆️
courier/template/testhelpers/testhelpers.go 95.06% <95.06%> (ø)
cmd/identities/validate.go 62.12% <100.00%> (ø)
courier/courier.go 69.44% <100.00%> (ø)
courier/template/recovery_invalid.go 100.00% <100.00%> (ø)
courier/template/recovery_valid.go 100.00% <100.00%> (ø)
courier/template/stub.go 100.00% <100.00%> (ø)
courier/template/verification_invalid.go 100.00% <100.00%> (ø)
courier/template/verification_valid.go 100.00% <100.00%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e48952...e09d481. Read the comment docs.

@aeneasr aeneasr merged commit de61ed0 into v0.8 Feb 14, 2022
@aeneasr aeneasr deleted the fix/makefile-rule branch February 14, 2022 16:02
aeneasr pushed a commit that referenced this pull request Feb 14, 2022
@icyphox @aeneasr
fix: incorrect makefile rule (#2222)
83a0ce7
This was referenced Mar 9, 2022
Merged
Merged
@vinckr vinckr mentioned this pull request Mar 18, 2022
Merged
@vinckr vinckr mentioned this pull request Apr 22, 2022
Merged
7 tasks
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@icyphox @aeneasr
fix: incorrect makefile rule (ory#2222)
4ba7b98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr left review comments

@zepatrik zepatrik Awaiting requested review from zepatrik zepatrik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icyphox @aeneasr