Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: appropriately pass context around #2241

Merged
merged 2 commits into from
Feb 21, 2022
Merged

fix: appropriately pass context around #2241

merged 2 commits into from
Feb 21, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 21, 2022

Closes ory/network#56

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr self-assigned this Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #2241 (2666e05) into master (506a0f1) will decrease coverage by 0.03%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2241      +/-   ##
==========================================
- Coverage   75.88%   75.85%   -0.04%     
==========================================
  Files         297      297              
  Lines       15909    15909              
==========================================
- Hits        12073    12067       -6     
- Misses       2978     2982       +4     
- Partials      858      860       +2     
Impacted Files Coverage Δ
cmd/hashers/argon2/root.go 18.18% <0.00%> (ø)
selfservice/flow/settings/error.go 77.47% <0.00%> (ø)
selfservice/flow/settings/handler.go 68.49% <0.00%> (ø)
selfservice/flow/settings/sort.go 100.00% <100.00%> (ø)
persistence/sql/persister_courier.go 85.00% <0.00%> (-3.34%) ⬇️
session/test/persistence.go 98.61% <0.00%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506a0f1...2666e05. Read the comment docs.

@aeneasr aeneasr merged commit 668f6b2 into master Feb 21, 2022
@aeneasr aeneasr deleted the fix-loader branch February 21, 2022 12:39
@vinckr vinckr mentioned this pull request Mar 18, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing schema leads to error 500 (on hosted ui)
1 participant