Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add CourierConfig to default registry #2243

Merged
merged 1 commit into from
Feb 21, 2022
Merged

fix: add CourierConfig to default registry #2243

merged 1 commit into from
Feb 21, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 21, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr self-assigned this Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #2243 (e345fe6) into master (506a0f1) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e345fe6 differs from pull request most recent head 5390a13. Consider uploading reports for the commit 5390a13 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
- Coverage   75.88%   75.87%   -0.02%     
==========================================
  Files         297      297              
  Lines       15909    15909              
==========================================
- Hits        12073    12071       -2     
- Misses       2978     2979       +1     
- Partials      858      859       +1     
Impacted Files Coverage Δ
driver/registry.go 73.33% <ø> (ø)
persistence/sql/persister_courier.go 85.00% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506a0f1...5390a13. Read the comment docs.

@aeneasr aeneasr merged commit 2e1fba3 into master Feb 21, 2022
@aeneasr aeneasr deleted the fix-courier branch February 21, 2022 12:37
@vinckr vinckr mentioned this pull request Mar 18, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant