Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename whitelisted_return_urls to allowed_return_urls #2299

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Mar 10, 2022

BREAKING CHANGE: Configuration key selfservice.whitelisted_return_urls has been renamed to allowed_return_urls.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

BREAKING CHANGE: Configuration key `selfservice.whitelisted_return_urls` has been renamed to `allowed_return_urls`.
@aeneasr aeneasr requested a review from zepatrik as a code owner March 10, 2022 16:06
@aeneasr aeneasr self-assigned this Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2299 (6617992) into master (e1e7516) will not change coverage.
The diff coverage is 96.00%.

❗ Current head 6617992 differs from pull request most recent head 14cff83. Consider uploading reports for the commit 14cff83 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2299   +/-   ##
=======================================
  Coverage   76.56%   76.56%           
=======================================
  Files         318      318           
  Lines       17148    17148           
=======================================
  Hits        13129    13129           
  Misses       3087     3087           
  Partials      932      932           
Impacted Files Coverage Δ
driver/config/config.go 81.69% <80.00%> (ø)
selfservice/flow/login/flow.go 96.49% <100.00%> (ø)
selfservice/flow/login/handler.go 80.48% <100.00%> (ø)
selfservice/flow/login/hook.go 89.01% <100.00%> (ø)
selfservice/flow/logout/handler.go 83.58% <100.00%> (ø)
selfservice/flow/recovery/flow.go 93.44% <100.00%> (ø)
selfservice/flow/registration/flow.go 100.00% <100.00%> (ø)
selfservice/flow/registration/hook.go 84.15% <100.00%> (ø)
selfservice/flow/settings/flow.go 93.22% <100.00%> (ø)
selfservice/flow/settings/hook.go 72.80% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e7516...14cff83. Read the comment docs.

@aeneasr aeneasr merged commit 686c9ba into master Mar 11, 2022
@aeneasr aeneasr deleted the fix-whitelisted branch March 11, 2022 09:04
@vinckr vinckr mentioned this pull request Mar 18, 2022
peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
…ry#2299)

BREAKING CHANGE: Configuration key `selfservice.whitelisted_return_urls` has been renamed to `allowed_return_urls`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant