Upgrade to Go 1.21.13 #1349
Upgrade to Go 1.21.13 #1349
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
|
gosec has some new rules apparently... just to make file perms explicit it seems. |
|
Yeah I was already looking into it yesterday but got disturbed. Let’s see... |
|
|
cmd/oscap/main.go
Outdated
| @@ -233,7 +233,7 @@ func generateJson(dir, datastreamDistro, profileDescription, profile string) { | |||
| } | |||
| // hack to add an empty line at the end of the file for nicer diffs | |||
| bArray = append(bArray, '\n') | |||
| err = os.WriteFile(path.Join(dir, "customizations.json"), bArray, os.ModePerm) | |||
| err = os.WriteFile(path.Join(dir, "customizations.json"), bArray, 0640) | |||
There was a problem hiding this comment.
Lets just disable the rule here? sounds bit too strict and seems it might be tricky to verify 0600 would work as well here.
There was a problem hiding this comment.
@croissanne can you comment? I am not sure what this does, shall I set 666 here? this looks like some kind of generator where 600 should be fine I guess.
|
So it now passes with 0600 for customization, should be fine according to @croissanne Tho there is a snag on CI: |
|
Ok I mixed two problems together accidentally. What I am trying to solve is this problem: This is unrelated to that, I am closing this for now, |
Dependa bots latest update
gosecis complaining about old Go version, let’s bump it:#1348
Also bumping some dependencies too.