build: pin oapi-gen until toolbox gets 1.21.13 #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about pinning it in the files which have the directive ? or |
|
For the record the problem is auto-updating of dependencies: Asked on Slack and got few recommendations and an article link which I am going to read in a bit. A recommendation was to use |
|
Slightly tuned the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
lzap
force-pushed
the
pin-oapi
branch
2 times, most recently
from
4829b69
to
67b8199
Compare
|
Okay messed up |
lzap
commented
Sep 24, 2024
tools/prepare-source.sh
Outdated
| @@ -12,7 +13,8 @@ $GO_BINARY download | |||
| # Ensure dev tools are installed | |||
| which goimports || $GO_BINARY install golang.org/x/tools/cmd/goimports@latest | |||
|
|
|||
| # Ensure that all code has been regenerated from its sources | |||
| # Ensure that all code has been regenerated from its sources with the pinned oapi version | |||
| git grep -l "github.com/oapi-codegen/oapi-codegen/v2/cmd/[email protected]" | grep -v prepare-source.sh | xargs sed -i "s|github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen[[email protected]]*|github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen@v$OAPI_VERSION|g" | |||
There was a problem hiding this comment.
LOL keeps modifying this file too.
Bumps the go-deps group with 1 update: [github.com/osbuild/images](https://github.com/osbuild/images). Updates `github.com/osbuild/images` from 0.87.0 to 0.88.0 - [Release notes](https://github.com/osbuild/images/releases) - [Commits](osbuild/images@v0.87.0...v0.88.0) --- updated-dependencies: - dependency-name: github.com/osbuild/images dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps ... Signed-off-by: dependabot[bot] <[email protected]>
|
dumb question: Why cannot we use Go 1.21.13? |
|
Ah, is that because |
#1349 failed to do it easily |
|
Looks 🍏 to me 🤷 |
|
Exactly, the thing is some go tools now tries to upgrade to latest version which is causing the issue. Namely Tests are green. |
|
I see no objections, lets get it in :) |
ezr-ondrej
approved these changes
Sep 25, 2024
jamietanna
added a commit
to oapi-codegen/oapi-codegen
that referenced
this pull request
Sep 28, 2024
Originally added in f77bd7b, we wanted to pin the version to ensure that we were targeting the latest version of Go 1.21. However, there's no real value here, and as noted in [0] it can be causing issues for some users. There's nothing explicitly in Go 1.21.x that we need to pin to, just that we need support for Go 1.21, so we can use Speakeasy's `openapi-overlay` library. Therefore we can relax the patch-version requirement, which will alleviate issues for consumers. [0]: osbuild/image-builder#1352
jamietanna
added a commit
to oapi-codegen/oapi-codegen
that referenced
this pull request
Sep 28, 2024
Originally added in f77bd7b, we wanted to pin the version to ensure that we were targeting the latest version of Go 1.21. However, there's no real value here, and as noted in [0] it can be causing issues for some users. There's nothing explicitly in Go 1.21.x that we need to pin to, just that we need support for Go 1.21, so we can use Speakeasy's `openapi-overlay` library. Therefore we can relax the patch-version requirement, which will alleviate issues for consumers. This makes sure that we have _at a minimum_ a version of Go 1.21, and makes `go mod tidy` happy. [0]: osbuild/image-builder#1352
jamietanna
added a commit
to oapi-codegen/oapi-codegen
that referenced
this pull request
Sep 28, 2024
Originally added in f77bd7b, we wanted to pin the version to ensure that we were targeting the latest version of Go 1.21. However, there's no real value here, and as noted in [0] it can be causing issues for some users. There's nothing explicitly in Go 1.21.x that we need to pin to, just that we need support for Go 1.21, so we can use Speakeasy's `openapi-overlay` library. Therefore we can relax the patch-version requirement, which will alleviate issues for consumers. This makes sure that we have _at a minimum_ a version of Go 1.21, and makes `go mod tidy` happy. [0]: osbuild/image-builder#1352
jamietanna
added a commit
to oapi-codegen/oapi-codegen
that referenced
this pull request
Sep 28, 2024
Originally added in f77bd7b, we wanted to pin the version to ensure that we were targeting the latest version of Go 1.21. However, there's no real value here, and as noted in [0] it can be causing issues for some users. There's nothing explicitly in Go 1.21.x that we need to pin to, just that we need support for Go 1.21, so we can use Speakeasy's `openapi-overlay` library. Therefore we can relax the patch-version requirement, which will alleviate issues for consumers. This makes sure that we have _at a minimum_ a version of Go 1.21, and makes `go mod tidy` happy. [0]: osbuild/image-builder#1352
|
Apologies for this! https://github.com/oapi-codegen/oapi-codegen/releases/tag/v2.4.1 should now resolve this for y'all 🤞 |
|
Jeeeez Jamie, no need to apologize. Thank you for your help on the Go Slack channel and for your hard work on this project, and many more! Let’s revert the hack (or keep it): #1355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure how to implement pinning effectively for vendored projects. What I usually do is manually
go getthose libraries in a prepare script or Makefile.