disk: define PartitionTableType enum for partition table types #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be rebased on #1002. |
Add a new enum, PartitionTableType, for referring to the two partition table types, "dos" and "gpt". This is currently not used but will be part of the new custom partition table generator.
achilleas-k
force-pushed
the
disk/pttype
branch
from
7abc7e4
to
78d183f
Compare
mvo5
previously approved these changes
Nov 4, 2024
No no, it's my fault. I should have known and done it already. |
achilleas-k
force-pushed
the
disk/pttype
branch
from
6354e01
to
3cde601
Compare
Added TWO! |
mvo5
reviewed
Nov 5, 2024
mvo5
reviewed
Nov 5, 2024
achilleas-k
force-pushed
the
disk/pttype
branch
from
3cde601
to
831d4a4
Compare
|
Merging this because I'm going to need it for #1009. |
Actually didn't end up depending. I was thinking of using the new enums in the PartitionTable but it's a bigger change that I'd rather do in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #926 which I'm slowly splitting into smaller, bite-sized PRs.
Add a new enum, PartitionTableType, for referring to the two partition table types, "dos" and "gpt".
This is currently not used but will be part of the new custom partition table generator.