Partition table helper functions for adding root filesystem and boot partition #1009
+1,086
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
previously approved these changes
Nov 4, 2024
achilleas-k
force-pushed
the
disk/pt/helper-functions
branch
from
a439666
to
ee848d1
Compare
ondrejbudai
previously approved these changes
Nov 5, 2024
Add a function that takes a partition table and adds a root filesystem, but only if one does not already exist. A root filesystem is any mountable where the mountpoint is `/`. The function decides whether to create a plain partition, a logical volume, or a btrfs subvolume based on existing partitions and volumes in the partition table. This function is not currently used because our base partition tables always have root filesystems, but it will be part of the new custom partition table generator.
achilleas-k
force-pushed
the
disk/pt/helper-functions
branch
from
ee848d1
to
2ea0951
Compare
mvo5
previously approved these changes
Nov 6, 2024
achilleas-k
dismissed
mvo5’s stale review
The merge-base changed after approval.
Add a function that takes a partition table and adds a boot partition, but only if one does not already exist. A boot partition is any mountable where the mountpoint is `/boot`. Although the /boot mountpoint must always be on a plain partition, this is not validated. This function is not currently used because the NewPartitionTable() function handles this automatically during layout conversions (in ensureLVM() and ensureBtrfs()), but it will be part of the new custom partition table generator.
Define a new const string: DosLinuxTypeID, which is used for Linux filesystems on dos/mbr partition tables. In the new helper functions, use the partition table type to determine which ID to use. This means that the functions will return an error when the partition table type is not set (or is set to an unknown value). Update the tests to match the new behaviour and to test the correct ID selection.
achilleas-k
force-pushed
the
disk/pt/helper-functions
branch
from
2ea0951
to
88d6a6a
Compare
mvo5
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #926 which I'm slowly splitting into smaller, bite-sized PRs.
The PR introduces two helper functions,
EnsureRootFilesystem()andEnsureBootPartition(). These will add, respectively, a root filesystem and a boot partition to a partition table if they don't already exist.