Enables 'fdo.di_mfg_string_type_mac_iface' variable passing #208
Conversation
|
This PR is linked to osbuild/osbuild-composer#3743, which enables 'fdo.di_mfg_string_type_mac_iface' passing in osbuild-composer. |
|
Some testing will be good, rest changes LGTM. |
djach7
force-pushed
the
ifaceHandling
branch
3 times, most recently
from
43880e3
to
7cc5d9c
Compare
|
What's the status on this? I don't mind merging with a manual test for now and then adding a test in osbuild-composer's CI when the support is added there. Is there a way we can test it here? |
|
@achilleas-k We would need to test that this new kernel argument is passed when the option appears in the blueprint, does it make more sense to test that in composer? |
Yes, let's do that in composer CI. For this PR, a quick manual test should be enough to get it through then we can rely on composer testing it automatically until we move some of that testing to this repository. |
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
We still want to get this merged for RHEL for Edge/FDO purposes; I can't remove the |
Removed |
|
@achilleas-k Apologies, I was in class all of last week. This should be good to go, and the sister PR should also be good to go pending review and removal of testing commit. Please let me know if there's anything I need to do. Link to sister PR in osbuild/osbuild-composer: osbuild/osbuild-composer#3743 |
|
Merge conflicts. Sorry about that :/ |
Makes necessary changes for 'fdo.di_mfg_string_type_mac_iface' variable to be passed to manufacturing-client.service when the manufacturing-client is run via the simplified-installer.
djach7
force-pushed
the
ifaceHandling
branch
from
7cc5d9c
to
572479e
Compare
Makes necessary changes for 'fdo.di_mfg_string_type_mac_iface' variable to be passed to manufacturing-client.service when the manufacturing-client is run via the simplified-installer.