Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables 'fdo.di_mfg_string_type_mac_iface' variable passing #3743

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

djach7
Copy link
Contributor

@djach7 djach7 commented Oct 16, 2023

Adds implementation of the 'fdo.di_mfg_string_type_mac_iface' dracut variable to allow simplified installer images to pass this value to the manufacturing-client.service.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@djach7
Copy link
Contributor Author

djach7 commented Oct 16, 2023

This PR is linked to osbuild/images#208, which enables 'fdo.di_mfg_string_type_mac_iface' passing in the images repo.

@miabbott
Copy link

See #3723 for an example of how to vendor in a copy of osbuild/images which may allow the CI to run successfully

@7flying 7flying added the WIP+test Work in progress but run Gitlab CI. label Oct 24, 2023
@djach7 djach7 marked this pull request as ready for review October 26, 2023 15:19
@djach7 djach7 marked this pull request as draft October 26, 2023 17:08
@djach7 djach7 force-pushed the ifaceHandling branch 3 times, most recently from 07694c4 to 5c428dd Compare October 26, 2023 18:28
@achilleas-k achilleas-k self-requested a review October 26, 2023 18:33
@djach7 djach7 force-pushed the ifaceHandling branch 4 times, most recently from fb1b886 to cb64ab1 Compare October 30, 2023 19:46
@djach7 djach7 marked this pull request as ready for review October 31, 2023 14:31
@djach7 djach7 force-pushed the ifaceHandling branch 2 times, most recently from 75a76f0 to 2cadc0b Compare October 31, 2023 18:25
@croissanne
Copy link
Member

Rebased to prevent OCI private key leaking. Apologies :(

@djach7 djach7 force-pushed the ifaceHandling branch 6 times, most recently from 1a7514d to b3778b7 Compare November 15, 2023 17:23
@djach7 djach7 force-pushed the ifaceHandling branch 2 times, most recently from e88a544 to 6ee84f5 Compare December 12, 2023 18:46
@achilleas-k achilleas-k removed the WIP+test Work in progress but run Gitlab CI. label Dec 12, 2023
@achilleas-k achilleas-k enabled auto-merge (rebase) December 12, 2023 19:22
achilleas-k
achilleas-k previously approved these changes Dec 12, 2023
Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a minor commit rewrite and split for cleaner history.
LGTM.

achilleas-k and others added 3 commits December 14, 2023 11:58
Update the images dependency to v0.24.0

Includes the addition of the new FDO option
'di_mfg_string_type_mac_iface'.
Adds implementation of the 'fdo.di_mfg_string_type_mac_iface' dracut
variable to allow simplified installer images to pass this value to the
manufacturing-client.service.
@achilleas-k achilleas-k merged commit a4ebf53 into osbuild:main Dec 14, 2023
63 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants