feat: remove signatures in container deployments by default #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also canonically reference containers/image#2599 (in the code as well) |
ondrejbudai
previously approved these changes
Oct 18, 2024
mmartinv
force-pushed
the
container-deploy-remove-signatures
branch
from
d524795
to
32fa866
Compare
mmartinv
force-pushed
the
container-deploy-remove-signatures
branch
from
32fa866
to
7a4fcc0
Compare
mmartinv
force-pushed
the
container-deploy-remove-signatures
branch
from
7a4fcc0
to
ba6af52
Compare
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 22, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 22, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 23, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 23, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 23, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
achilleas-k
previously approved these changes
Oct 23, 2024
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 24, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 25, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 25, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 25, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
force-pushed
the
container-deploy-remove-signatures
branch
from
ba6af52
to
691be91
Compare
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 28, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 29, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
Make `skopeo copy` to remove the signatures of signed containers by default to avoid build failures until [1] is implemented. Depends: osbuild/osbuild#1906 Resolves: osbuild/bootc-image-builder#681 [1] containers/image#2599 Co-authored-by: Michael Vogt <[email protected]>
mmartinv
force-pushed
the
container-deploy-remove-signatures
branch
from
691be91
to
8049ad7
Compare
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Oct 30, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Nov 4, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Nov 4, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Nov 4, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Nov 5, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Nov 5, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Nov 5, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
added a commit
to mmartinv/bootc-image-builder
that referenced
this pull request
Nov 5, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Nov 5, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Nov 5, 2024
Add anaconda-iso iso build tests with signed containers. The rest of the images can be also added to the test once [1] and [2] are merged [1] osbuild/images#990 [2] osbuild/osbuild#1906 Signed-off-by: Miguel Martín <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
skopeo copyto remove the signatures of signed containers by default to workaround build failures until containers/image#2599 is implemented.Depends: osbuild/osbuild#1906
Resolves: osbuild/bootc-image-builder#681
Signed-off-by: Miguel Martín [email protected]