worker: move api.BasePath setup to the start of the funcs
#4328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it slightly eaiser to read this code when `api.BasePath = conf.BasePath` is right at the top as it's unrelated to the parsing code below. Note that the code itself is problematic: - api.BasePath is global but client is not, this means that multiple client with different configs will result in api.BasePath being potentially wrong - api.BasePath is set in a non-thread safe manner Changing is a bigger job but we might consider it (IMHO).
mvo5
force-pushed
the
client-worker-tweaks3
branch
from
20edf45
to
e2e06e2
Compare
|
despite this flaw in design, I think we can as well "assert" on startup (as a kind of mitigation) somehow that there is no second client and no second config, as this won't happen I guess |
schuellerf
approved these changes
Aug 26, 2024
mvo5
added a commit
to mvo5/osbuild-composer
that referenced
this pull request
Aug 26, 2024
The `api.BasePath` is package global but the way it is used is that multiple clients can (potentially) have different BasePath and the way it is written right now could lead to confusing bugs. This commit tweaks the `api` package so that `BasePath` does not need to be set. The only place that this is needed is for the `api.APIError()` which can just get the basePath as an argument. With that we also need a helper to construct the api error handler from the static HTTPErrorHandler to a dynamic MakeHTTPErrorHandler() that will return a handler for the given basePath. This should make osbuild#4328 obsolete.
thozza
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it slightly eaiser to read this code when
api.BasePath = conf.BasePathis right at the top as it's unrelated to the parsing code below.Note that the code itself is problematic:
Changing is a bigger job but we might consider it (IMHO).