worker: remove api.BasePath and replace with MakeHTTPErrorHandler()
#4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `api.BasePath` is package global but the way it is used is that multiple clients can (potentially) have different BasePath and the way it is written right now could lead to confusing bugs. This commit tweaks the `api` package so that `BasePath` does not need to be set. The only place that this is needed is for the `api.APIError()` which can just get the basePath as an argument. With that we also need a helper to construct the api error handler from the static HTTPErrorHandler to a dynamic MakeHTTPErrorHandler() that will return a handler for the given basePath. This should make osbuild#4328 obsolete.
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 30+7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as it currently has no tests :( ]
The
api.BasePathis package global but the way it is used is that multiple clients can (potentially) have different BasePath and the way it is written right now could lead to confusing bugs.This commit tweaks the
apipackage so thatBasePathdoes not need to be set. The only place that this is needed is for theapi.APIError()which can just get the basePath as an argument. With that we also need a helper to construct the api error handler from the static HTTPErrorHandler to a dynamic MakeHTTPErrorHandler() that will return a handler for the given basePath.This should make #4328 obsolete.