-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split libpolymake_julia into separate repo #304
Conversation
disabled custom path for polymake / libpolymake-julia for now
only the libcxxwrap version used at build-time seems relevant here
try to run on ubuntu 20.04 as well
Does this mean you cannot point to your own local polymake installation anymore? |
unfortunately yes, at least for now |
so according to github actions both cxxwrap 0.11 and cxxwrap 0.10 work, but 0.9 complains about a missing symbol. not really surprising since we built the library with latest libcxxwrap 0.8 (from cxxwrap 0.11). |
For a custom installation we need to have the path to a I thought about running the script via the shared library but we need to run that at precompilation before the library is really available. Maybe we could build a tiny script-runner executable linked against the same |
Weird, it seems that github actions was faster than github ... the run https://github.com/oscar-system/Polymake.jl/actions/runs/160331645 should not have succeeded but it used an older commit instead of the one that it refers to ... there is an undefined variable polymake_run_script in Polymake.jl that will come from a newer libpolymake_julia binary. edit: maybe this was something like this: actions/checkout#237 |
c0a05b4
to
d18d344
Compare
d18d344
to
7f3817c
Compare
I was trying to remove the builds for different |
uuu, all green! :) |
I was slightly surprised myself, no errors, even without separate builds per gcc / libstdc++ version. The previous crashes were coming from a missing shell enable in the script runner. There are still a few things that I want to do:
|
update many dependencies to jll based binaries, but using legacy installation as building the interface and wrappers wont work otherwise (at least for now) flint_jll currently at 0.0.2 (which corresponds to pre 2.6) for compatibility reasons
libpolymake-julia lives here: https://github.com/oscar-system/libpolymake-julia
I have deployed a first set of binaries: https://github.com/benlorenz/libpolymake_julia_jll.jl
advantages:
disadvantages:
one could try to install a custom
polymake
+libpolymake_julia
intodeps/usr
after installing the binaries once, as long as all products are satisfied this should not be overwritten