-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #172. LDAP_BASE_DN env was not used for the actual LDAP base #238
Conversation
When environmentvariables have been set like this: LDAP_BASE_DN="o=some org,c=com" LDAP_DOMAIN="some-org.com" The base dn of the generated LDAP is dc=some-org,dc=com instead of o=some org,c=com This commit fixes that
1. Changed ldapmodify for olcSuffix and olcRootDN in 02-security.ldif to use replace instead of delete/add 2. Added quotes to the Base DN at ldap_add_or_modify in startup.sh because X.500 compliant Base DNs might contain whitspace.
Actually this is not the only thing that needs to be done in order to enable Base DN in X.500 format.
|
Hello, |
Hi, yes the 2nd comment is about the same thing.
I might be possible to solve number 3 using a script by adding the Base-DN entry using the information from the LDAP_BASE_DN environment variable. Easier would be to explain in the documentation that users have to add an LDIF file as explained in the comment if they want to choose a LDAP_BASE_DN that is not derived from the LDAP_DOMAIN. |
This is related to #307. There I have discovered that |
I have the feeling that https://serverfault.com/a/469400/93281 is more or less related to this problem, am I wrong? |
For example, in order for me to take my parameter
I must write those 2 files into
|
So what's the outcome? |
When environmentvariables have been set like this:
LDAP_BASE_DN="o=some org,c=com"
LDAP_DOMAIN="some-org.com"
The base dn of the generated LDAP is dc=some-org,dc=com instead of o=some org,c=com
This commit fixes that.
It might be better to move the change to a file different from 02-security.ldif or maybe renaming it as this might be confusing otherwise.