Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go work sync #5063

Closed
wants to merge 3 commits into from
Closed

go work sync #5063

wants to merge 3 commits into from

Conversation

faddat
Copy link
Member

@faddat faddat commented May 3, 2023

What is the purpose of the change

This PR is me running go work sync, and when I did that a number of go.mod
and go.sum files were changed. The repository passes tests, so I have
assumed that this is "a good thing"TM. Please close this if not desired.

Brief Changelog

go work sync

Testing and Verifying

This is a highly trivial change unworthy of a change to the changelog.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior
    changes? no
  • Is a relevant changelog entry added to the Unreleased section in
    CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@faddat
Copy link
Member Author

faddat commented May 3, 2023

changelog reminder ftw

@faddat faddat added A:backport/v15.x backport patches to v15.x branch V:state/compatible/backport State machine compatible PR, should be backported labels May 3, 2023
@faddat
Copy link
Member Author

faddat commented May 3, 2023

(force pushed to remove two unnecessary commits that should have gone on another branch)

@p0mvn
Copy link
Member

p0mvn commented May 3, 2023

@faddat merged main here and removed changelog entry while doing so because the change is not client facing. Hope you don't mind

Will merge this in as soon as CI passs. Thank you

@p0mvn
Copy link
Member

p0mvn commented May 3, 2023

Actually, it looks like this change has already gotten in with your other PR: #5065

Making this obsolete after merging main. As a result, going to close this. Please let me know if something isn't right here

@p0mvn p0mvn closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v15.x backport patches to v15.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants