refactor: use cosmossdk.io/errors #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
mattverse,
stackman27,
nicolaslara,
p0mvn and
czarcas7ic
as code owners
github-actions
bot
added
C:app-wiring
faddat
added
A:backport/v15.x
faddat
added
V:state/compatible/backport
|
regarding labels: only backport this to v15 |
nicolaslara
reviewed
May 3, 2023
nicolaslara
reviewed
May 3, 2023
nicolaslara
approved these changes
May 3, 2023
|
@nicolaslara sir, do you have any idea what might be making my editor defy me? I didn't make the change to the backlog link..... I'll manually fix but suspect it happened because I hit ctrl+s -- will look into it from my end too (maybe markdownlint?) |
|
lol, yeah, no idea. I've had my editor do stuff like that too. If the editor refuses I can fix it (emacs! :) ) |
|
@nicolaslara I've fixed it -- those links had a space between ] and ( so my editor did magic to them |
mergify bot
pushed a commit
that referenced
this pull request
May 3, 2023
* use cosmossdk.io/errors * update changelog * fix links so they don't violate no-bare-url (cherry picked from commit 560224f) # Conflicts: # CHANGELOG.md # app/params/config.go # go.mod # go.sum # osmomath/go.mod # osmoutils/go.mod # tests/cl-genesis-positions/go.mod # tests/cl-go-client/go.mod # tests/cl-go-client/go.sum # x/concentrated-liquidity/incentives_test.go # x/cosmwasmpool/model/msgs.go # x/epochs/go.mod # x/epochs/go.sum # x/gamm/handler.go # x/gamm/keeper/migrate_test.go # x/gamm/pool-models/balancer/msgs.go # x/ibc-hooks/go.mod # x/ibc-hooks/go.sum # x/pool-incentives/types/errors.go # x/superfluid/keeper/migrate_test.go # x/superfluid/keeper/stake_test.go # x/superfluid/keeper/superfluid_asset_store.go # x/superfluid/types/msgs.go # x/tokenfactory/keeper/before_send.go # x/tokenfactory/types/errors.go # x/tokenfactory/types/msgs.go
Closed
18 tasks
pysel
pushed a commit
that referenced
this pull request
Jun 6, 2023
* use cosmossdk.io/errors * update changelog * fix links so they don't violate no-bare-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Make upgrading to sdk v0.47.x easier by adopting cosmossdk.io/errors where applicable while
still using sdk v0.45.x
Brief Changelog
Testing and Verifying
This should pass all existing tests without issue
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes