-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document propOmega, flip thruster, fix coefficient #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
This was referenced Nov 12, 2021
chapulina
force-pushed
the
chapulina/flip_thruster
branch
from
November 16, 2021 04:10
dd0a815
to
658f213
Compare
Signed-off-by: Louise Poubel <[email protected]>
This was
linked to
issues
Nov 16, 2021
Merged
Signed-off-by: Louise Poubel <[email protected]>
arjo129
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes. The PR Looks Good To Me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The propeller joint's axis was pointing to the vehicle's back, which caused the vehicle to be propelled forward for negative thrust forces. This PR flip the axis so that clockwise rotations when looking from the back cause the vehicle to move forward:
propOmega
TethysComm
was using 0.0016 m for the propeller diameter, but theThruster
uses 0.2 m, taken from the SDF. I updatedTethysComm
to use 0.2 m, and that made the vehicle extremely fast. So I reduced the coefficient 100x to compensate.and make the tolerances tighter (from 12 m / 1.57 rad to 1.5 m / 0.1 rad!!!)and remove the specific trajectory check, because it was too hard to maintain and failures weren't useful 🪀