Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document propOmega, flip thruster, fix coefficient #76

Merged
merged 8 commits into from
Nov 22, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Nov 12, 2021


The propeller joint's axis was pointing to the vehicle's back, which caused the vehicle to be propelled forward for negative thrust forces. This PR flip the axis so that clockwise rotations when looking from the back cause the vehicle to move forward:

image

thruster

  • Documented propOmega
  • Flipped the propeller joint, and flipped the commands accordingly
  • Fixed the conversion from angular velocity to force. The formula on TethysComm was using 0.0016 m for the propeller diameter, but the Thruster uses 0.2 m, taken from the SDF. I updated TethysComm to use 0.2 m, and that made the vehicle extremely fast. So I reduced the coefficient 100x to compensate.
  • Updated a few test expectations to the new thrust. In particular, yoyo is spinning a bit faster now. I also took the opportunity to add more checks to yoyo, and make the tolerances tighter (from 12 m / 1.57 rad to 1.5 m / 0.1 rad!!!) and remove the specific trajectory check, because it was too hard to maintain and failures weren't useful 🪀

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina mentioned this pull request Nov 16, 2021
@chapulina chapulina self-assigned this Nov 17, 2021
Base automatically changed from chapulina/upstream_thruster to main November 17, 2021 18:21
Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. The PR Looks Good To Me.

@chapulina chapulina merged commit b8a330a into main Nov 22, 2021
@chapulina chapulina deleted the chapulina/flip_thruster branch November 22, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document / update coordinates and units [Thruster plugin] Flip sign direction.
2 participants