Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ€¦β€β™€οΈ Fix thruster coefficient #90

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

chapulina
Copy link
Contributor

From #76:

The formula on TethysComm was using 0.0016 m for the propeller diameter, but the Thruster uses 0.2 m, taken from the SDF.

Well... I forgot the ^4 ... 0.0016 == 0.2 ^ 4 😬 This PR reverts it back.

I updated TethysComm to use 0.2 m, and that made the vehicle extremely fast. So I reduced the coefficient 100x to compensate.

This PR reverts it back... 😬

Updated a few test expectations to the new thrust.

Yeah, updating that again...

we're converting from ang vel to force and back. It would reduce errors if we only converted once.

Case in point πŸ™ƒ


I discovered this while working on a test for the state message on #81 . I broke off just the propOmega checks into this PR.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina self-assigned this Nov 23, 2021
Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this.

@chapulina chapulina merged commit a6ce8b8 into main Nov 24, 2021
@chapulina chapulina deleted the chapulina/thruster_again branch November 24, 2021 01:16
@arjo129 arjo129 mentioned this pull request Nov 24, 2021
@mabelzhang mabelzhang mentioned this pull request Nov 20, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants