Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfy ament linters #10

Merged
merged 14 commits into from
Apr 28, 2022
Merged

Satisfy ament linters #10

merged 14 commits into from
Apr 28, 2022

Conversation

quarkytale
Copy link
Contributor

@quarkytale quarkytale commented Apr 14, 2022

Would go after #9.

Used [ament_code_style.cfg]
Copyright, cpplint and uncrustify cleared!

Flake is failing but seems unrelated:

4: -- run_test.py: invoking following command in '/github/home/ws/src/buoy_sim/buoy_gazebo':
4:  - /opt/ros/galactic/bin/ament_flake8 --xunit-file /github/home/ws/build/buoy_gazebo/test_results/buoy_gazebo/flake8.xunit.xml
4: 
4: ./launch/electrohydraulic_pto.launch.py:48:100: E501 line too long (116 > 99 characters)
4:             '/model/Hydraulics_Test/joint/HydraulicRam/UserCommandedCurr@std_msgs/msg/Float64]ignition.msgs.Double',

@quarkytale quarkytale linked an issue Apr 14, 2022 that may be closed by this pull request
@chapulina chapulina changed the base branch from main to quarkytale/plugin_dirs April 14, 2022 00:44
@chapulina chapulina changed the base branch from quarkytale/plugin_dirs to main April 14, 2022 00:44
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me so far! Just a small comment.

buoy_gazebo/src/ElectroHydraulicPTO/ElectroHydraulicPTO.cc Outdated Show resolved Hide resolved
@quarkytale
Copy link
Contributor Author

This is too messy to fix as well as review. Working on separate PRs for individual test-failures fixes.

Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
@quarkytale quarkytale marked this pull request as ready for review April 27, 2022 04:37
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flake is failing but seems unrelated:

Ah that was introduced by me on #13 , I'll take care of it on another PR

double BattDrawLimit;
double RPMStdDev;
double BiasCurrent;
short Status; //should be 16 bits...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andermi , was there a reason not to use int16_t here before? We're about to change it to int16_t because of this warning:

Use int16/int64/etc, rather than the C type short  [runtime/int] [4]

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating, LGTM! Let's keep the short change for now, let's just keep in mind that this was done in case it creates problems.

@chapulina chapulina merged commit fa6a1f2 into main Apr 28, 2022
@chapulina chapulina deleted the quarkytale/satisfy_linters branch April 28, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Satisfy ament linters
2 participants