-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satisfy ament linters #10
Conversation
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me so far! Just a small comment.
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
This is too messy to fix as well as review. Working on separate PRs for individual test-failures fixes. |
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
This reverts commit a8b6de0.
Signed-off-by: quarkytale <[email protected]>
Signed-off-by: quarkytale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flake is failing but seems unrelated:
Ah that was introduced by me on #13 , I'll take care of it on another PR
double BattDrawLimit; | ||
double RPMStdDev; | ||
double BiasCurrent; | ||
short Status; //should be 16 bits... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andermi , was there a reason not to use int16_t
here before? We're about to change it to int16_t
because of this warning:
Use int16/int64/etc, rather than the C type short [runtime/int] [4]
Signed-off-by: quarkytale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating, LGTM! Let's keep the short
change for now, let's just keep in mind that this was done in case it creates problems.
Would go after #9.
Used [ament_code_style.cfg]
Copyright, cpplint and uncrustify cleared!
Flake is failing but seems unrelated: